repomaker merge requestshttps://staging.gitlab.com/fdroid/repomaker/-/merge_requests2017-08-09T07:13:21Zhttps://staging.gitlab.com/fdroid/repomaker/-/merge_requests/149Prevent background tasks from running within one transaction (on desktop)2017-08-09T07:13:21Zusername-removed-26331Prevent background tasks from running within one transaction (on desktop)This is based on top of !148.This is based on top of !148.1.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/148Download App Icons in Dedicated Background Tasks2017-08-09T06:52:28Zusername-removed-26331Download App Icons in Dedicated Background Tasks1.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/147Improve CI stages and fix cache2017-08-06T17:39:54Zusername-removed-26331Improve CI stages and fix cacheAlso fix fdroidserver dependency as it is now on pypi.Also fix fdroidserver dependency as it is now on pypi.1.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/146Parallelize tests2017-08-01T11:59:19Zusername-removed-124398Parallelize testsInstead of longly talking about it, I just did it quickly. Seems like my theory used in reality is wrong because there's no significant improvement in terms of speed. Our jobs mostly depend on how quickly GitLab pulls down the images.
L...Instead of longly talking about it, I just did it quickly. Seems like my theory used in reality is wrong because there's no significant improvement in terms of speed. Our jobs mostly depend on how quickly GitLab pulls down the images.
Latest `master` pipelines:
* 00:02:24
* 00:03:32
* 00:04:04
* 00:05:42
* 00:03:00
* 00:05:25
This MR's pipelines:
* 00:03:19
* 00:02:37username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/145Add files for building a vendorized Debian package2017-08-01T08:01:19Zusername-removed-26331Add files for building a vendorized Debian packageThis also includes a commit that does some system checks before starting repomaker.This also includes a commit that does some system checks before starting repomaker.1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/144More work towards making repomaker installable2017-07-27T21:35:06Zusername-removed-26331More work towards making repomaker installableThis MR makes repomaker installable with pip and is already functional.
Next up is creating Debian packages.This MR makes repomaker installable with pip and is already functional.
Next up is creating Debian packages.1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/143Make Repomaker installable2017-07-24T20:46:11Zusername-removed-26331Make Repomaker installableThis is based on !142 and not ready yet. I still post it here already, because it changes quite a bit in the repo and therefore new work should be based on this rather than `master`.This is based on !142 and not ready yet. I still post it here already, because it changes quite a bit in the repo and therefore new work should be based on this rather than `master`.1.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/142Adapt to new stretch-based CI2017-07-21T06:21:32Zusername-removed-26331Adapt to new stretch-based CIWith the new CI image, 200 tests ran in 2 minutes and 26 seconds.With the new CI image, 200 tests ran in 2 minutes and 26 seconds.1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/141Re-sign test APKs to prevent validation errors with MD5 signature2017-07-19T18:42:17Zusername-removed-26331Re-sign test APKs to prevent validation errors with MD5 signature1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/138Handle add and back in remote app add properly2017-07-19T14:38:55Zusername-removed-124398Handle add and back in remote app add properlyAdditionally, screenshots will be loaded via JavaScript if it is available.
Fixes #158.Additionally, screenshots will be loaded via JavaScript if it is available.
Fixes #158.1.0username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/135Fix Roboto fonts on external repo page2017-07-19T13:06:26Zusername-removed-124398Fix Roboto fonts on external repo pageUpstream changed the names of all directories to lower case in this commit:
https://github.com/choffmeister/roboto-fontface-bower/commit/afa0e006831247a99376372c993e1d021c1c9610
When updating external NPM resources with `npm install`...Upstream changed the names of all directories to lower case in this commit:
https://github.com/choffmeister/roboto-fontface-bower/commit/afa0e006831247a99376372c993e1d021c1c9610
When updating external NPM resources with `npm install`, the repo publishing task failed with this error message:
```bash
Traceback (most recent call last):
[...]
File "/home/nico/Work/Current/F-Droid/repomaker/maker/views/gitstorage.py", line 83, in form_valid
return super(GitUrlValidationMixin, self).form_valid(form)
File "/home/nico/Work/Current/F-Droid/repomaker/maker/views/sshstorage.py", line 48, in form_valid
return super(SshKeyMixin, self).form_valid(form)
File "/home/nico/Work/Current/F-Droid/repomaker/maker/views/storage.py", line 66, in form_valid
return super(StorageCreateView, self).form_valid(form)
File "/home/nico/Work/Current/F-Droid/repomaker/maker/views/storage.py", line 35, in form_valid
form.instance.repo.set_url(form.instance.get_repo_url())
File "/home/nico/Work/Current/F-Droid/repomaker/maker/models/repository.py", line 248, in set_url
self._generate_page()
File "/home/nico/Work/Current/F-Droid/repomaker/maker/models/repository.py", line 203, in _generate_page
self._copy_page_assets()
File "/home/nico/Work/Current/F-Droid/repomaker/maker/models/repository.py", line 243, in _copy_page_assets
copy(source, target)
File "/usr/lib/python3.4/shutil.py", line 228, in copy
copyfile(src, dst, follow_symlinks=follow_symlinks)
File "/usr/lib/python3.4/shutil.py", line 107, in copyfile
with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/home/nico/Work/Current/F-Droid/repomaker/node_modules/roboto-fontface/fonts/Roboto/Roboto-Bold.woff2'
```1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/139Fix redirect after removing APK from app2017-07-19T10:43:47Zusername-removed-26331Fix redirect after removing APK from appCloses #159Closes #1591.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/137Keep last app icon around2017-07-18T12:53:23Zusername-removed-26331Keep last app icon aroundFixes #152Fixes #1521.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/136Show error page when database is locked2017-07-18T09:10:48Zusername-removed-26331Show error page when database is lockedUnfortunately, I didn't find a way to improve the database locking when using SqLite. It is either locking all or nothing. Also, I couldn't find out how to lock the database only for short intervals while doing background tasks.
So th...Unfortunately, I didn't find a way to improve the database locking when using SqLite. It is either locking all or nothing. Also, I couldn't find out how to lock the database only for short intervals while doing background tasks.
So this MR at least adds an error page, so users know what is going on.
Closes #1151.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/123Implement UI Improvement for Single Repo App Index2017-07-18T00:54:57Zusername-removed-124398Implement UI Improvement for Single Repo App IndexApp edit had hard dependencies to the drag and drop area in repo index, therefore this got a little bit larger.
### Empty
![Screen_Shot_2017-06-26_at_12.03.33](/uploads/34821e14df46553e5593522f499af887/Screen_Shot_2017-06-26_at_12....App edit had hard dependencies to the drag and drop area in repo index, therefore this got a little bit larger.
### Empty
![Screen_Shot_2017-06-26_at_12.03.33](/uploads/34821e14df46553e5593522f499af887/Screen_Shot_2017-06-26_at_12.03.33.png)
### Three apps
![Screen_Shot_2017-06-26_at_12.03.02](/uploads/b9d0cea5ebdce30de497373e1cf3f348/Screen_Shot_2017-06-26_at_12.03.02.png)
### Pagination => Search
I'm not confident with the large white space at the top but because of the input field this space is sometimes necessary.
![Screen_Shot_2017-06-26_at_12.02.32](/uploads/57f32f9ecddc3bc80f66eeea709c0cb2/Screen_Shot_2017-06-26_at_12.02.32.png)
### App edit
![Screen_Shot_2017-06-26_at_12.02.19](/uploads/034cb8699f50332881909964e0e1e437/Screen_Shot_2017-06-26_at_12.02.19.png)
### Non-JS Fallback
![Screen_Shot_2017-06-26_at_12.13.10](/uploads/c150a950794601f70db337c293e01374/Screen_Shot_2017-06-26_at_12.13.10.png)1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/134Implement Workflow for Translating App Metadata2017-07-16T10:23:18Zusername-removed-26331Implement Workflow for Translating App Metadata@NicoAlt you had asked for everything in one MR and here you go! :wink:
This MR contains 10 logically separate commits and could be split further though.
There are some issues left. I created tickets for those and tagged them with...@NicoAlt you had asked for everything in one MR and here you go! :wink:
This MR contains 10 logically separate commits and could be split further though.
There are some issues left. I created tickets for those and tagged them with ~localization
Otherwise, the translation workflow should now be good enough to be merged.
Closes #1261.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/133Fix material icon in repo share view2017-07-06T20:33:12Zusername-removed-124398Fix material icon in repo share viewSorry for that, I should really stop copy'n'pasting classes across the project...
![Screen_Shot_2017-07-06_at_22.14.58](/uploads/569884d0efbef2069e0c27021ed355e2/Screen_Shot_2017-07-06_at_22.14.58.png)
_`rm-storage-header-*` is just fo...Sorry for that, I should really stop copy'n'pasting classes across the project...
![Screen_Shot_2017-07-06_at_22.14.58](/uploads/569884d0efbef2069e0c27021ed355e2/Screen_Shot_2017-07-06_at_22.14.58.png)
_`rm-storage-header-*` is just for centering, which is already done by `rm-repo-share-empty`._1.0username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/127Filter and paginate apps with AJAX requests in repo apps2017-07-06T20:05:38Zusername-removed-124398Filter and paginate apps with AJAX requests in repo appsFilter and paginate apps with AJAX requests
When JavaScript is available, Repomaker acts like before.
Otherwise it reacts on a scroll event in MDL's content container.
Every time the user scrolls to the bottom closer than 800 ...Filter and paginate apps with AJAX requests
When JavaScript is available, Repomaker acts like before.
Otherwise it reacts on a scroll event in MDL's content container.
Every time the user scrolls to the bottom closer than 800 pixels,
an AJAX request is made to the window URL,
extended by Django's built-in pagination paramter `?page=`.
On first load it will load the second page and saves '2' to HTML's session storage.
When the user scrolls again close to the bottom,
the script increases the page count by one and requests again.
If there are no more apps, Repomaker returns 404 resulting in disabling the script's pagination functionality.
When Repomaker returns some apps,
the script gets the first app card and uses this as a template for the loaded ones.
It replaces the icon, title and other properties of the app and appends it to the page.
Fixes #98.1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/132Check that uploaded APKs are a proper update to current app2017-07-06T09:47:26Zusername-removed-26331Check that uploaded APKs are a proper update to current appAlso refactor the messy upload code and add lots of tests
Closes #107Also refactor the messy upload code and add lots of tests
Closes #1071.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/131Handle failing download_remote_screenshot task when App was deleted2017-07-05T11:10:52Zusername-removed-26331Handle failing download_remote_screenshot task when App was deletedCloses #116Closes #1161.0username-removed-124398username-removed-124398