repomaker merge requestshttps://staging.gitlab.com/fdroid/repomaker/-/merge_requests2017-06-29T14:15:56Zhttps://staging.gitlab.com/fdroid/repomaker/-/merge_requests/113Internationalise JavaScript code2017-06-29T14:15:56Zusername-removed-124398Internationalise JavaScript codeI did not find any way to let Django add the translations from JavaScript to "django" instead of "django.js".
This is the code I tried:
```python
js_info_dict = {
'domain': 'django',
'packages': ('maker.apps.MakerConfig',),
}
...I did not find any way to let Django add the translations from JavaScript to "django" instead of "django.js".
This is the code I tried:
```python
js_info_dict = {
'domain': 'django',
'packages': ('maker.apps.MakerConfig',),
}
urlpatterns = [
# JavaScript Internationalisation
url(r'^jsi18n/$', javascript_catalog, js_info_dict, name='javascript-catalog'),
```1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/112Directly upload files after selection in repo index view2017-06-30T13:50:00Zusername-removed-124398Directly upload files after selection in repo index viewOnly works with JavaScript, fallback is old behavior.Only works with JavaScript, fallback is old behavior.1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/111Remove margin around repo pagination2017-06-30T14:14:20Zusername-removed-124398Remove margin around repo paginationIn !102 I introduced some margin. This fixes it while keeping the other panels looking good.
Unfortunately, on the screenshots it still looks like there is some margin o_O In reality, there is none.
![Screen_Shot_2017-06-20_at_18.19.51...In !102 I introduced some margin. This fixes it while keeping the other panels looking good.
Unfortunately, on the screenshots it still looks like there is some margin o_O In reality, there is none.
![Screen_Shot_2017-06-20_at_18.19.51](/uploads/7c429ba229fe41b79ec7e17d711abd1b/Screen_Shot_2017-06-20_at_18.19.51.png)
![Screen_Shot_2017-06-20_at_18.19.46](/uploads/d81c126b06146b6bcce8ba4230a6cb4f/Screen_Shot_2017-06-20_at_18.19.46.png)
![Screen_Shot_2017-06-20_at_18.19.58](/uploads/38aec796a662f5c38e52d1c46e2975c6/Screen_Shot_2017-06-20_at_18.19.58.png)
![Screen_Shot_2017-06-20_at_18.19.53](/uploads/541d401952a54ef3f3d71668d1b03585/Screen_Shot_2017-06-20_at_18.19.53.png)
![Screen_Shot_2017-06-20_at_18.20.00](/uploads/18e5954b45287d537a363fb2a196cc86/Screen_Shot_2017-06-20_at_18.20.00.png)
![Screen_Shot_2017-06-20_at_18.20.16](/uploads/65d586092c631e0498aee4b40fd03f13/Screen_Shot_2017-06-20_at_18.20.16.png)
![Screen_Shot_2017-06-20_at_18.20.22](/uploads/ac4f98ac1321bd68ac30bce5e4950c99/Screen_Shot_2017-06-20_at_18.20.22.png)
![Screen_Shot_2017-06-20_at_18.20.19](/uploads/2fe95deefcb6aabc47cb825cbaf0b1ea/Screen_Shot_2017-06-20_at_18.20.19.png)
![Screen_Shot_2017-06-20_at_18.20.24](/uploads/eaf4c4224662f72c8b024fac7e4973a7/Screen_Shot_2017-06-20_at_18.20.24.png)1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/110Change "Developed by" to "By"2017-06-30T12:58:31Zusername-removed-124398Change "Developed by" to "By"![Firefox_Screenshot_2017-06-20T15-56-54.057Z](/uploads/07a49f5d899e098a81a17a06828ae0a5/Firefox_Screenshot_2017-06-20T15-56-54.057Z.png)
![Firefox_Screenshot_2017-06-20T15-56-45.658Z](/uploads/e8157abaa30f189a747d9f460b4c3672/Firefox_S...![Firefox_Screenshot_2017-06-20T15-56-54.057Z](/uploads/07a49f5d899e098a81a17a06828ae0a5/Firefox_Screenshot_2017-06-20T15-56-54.057Z.png)
![Firefox_Screenshot_2017-06-20T15-56-45.658Z](/uploads/e8157abaa30f189a747d9f460b4c3672/Firefox_Screenshot_2017-06-20T15-56-45.658Z.png)
![Firefox_Screenshot_2017-06-20T15-57-06.468Z](/uploads/1c4a4a8c016abbd7b4e41ad4723c4a2d/Firefox_Screenshot_2017-06-20T15-57-06.468Z.png)1.0https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/109Split large files2017-06-15T19:06:40Zusername-removed-26331Split large fileshttps://staging.gitlab.com/fdroid/repomaker/-/merge_requests/108Translations2017-06-15T13:27:13Zusername-removed-26331Translationshttps://staging.gitlab.com/fdroid/repomaker/-/merge_requests/107Show proper error screen when uploading APK that is already there2017-06-15T13:03:57Zusername-removed-26331Show proper error screen when uploading APK that is already thereCloses #84Closes #841.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/106Add labels and hint texts to app edit mode2017-06-29T13:06:22Zusername-removed-26331Add labels and hint texts to app edit modeFixes #103Fixes #1031.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/105Basic support for other media types besides apps2017-06-20T07:42:19Zusername-removed-26331Basic support for other media types besides appsCloses #34Closes #341.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/104Add button to remove a repo2017-06-09T12:48:43Zusername-removed-124398Add button to remove a repo![Screen_Shot_2017-06-08_at_11.04.15](/uploads/dddea5bf5056c9864f857eeb575e83e6/Screen_Shot_2017-06-08_at_11.04.15.png)
![Screen_Shot_2017-06-08_at_10.57.24](/uploads/48564b9121d70d5f88328ca80b7ffb75/Screen_Shot_2017-06-08_at_10.57.24...![Screen_Shot_2017-06-08_at_11.04.15](/uploads/dddea5bf5056c9864f857eeb575e83e6/Screen_Shot_2017-06-08_at_11.04.15.png)
![Screen_Shot_2017-06-08_at_10.57.24](/uploads/48564b9121d70d5f88328ca80b7ffb75/Screen_Shot_2017-06-08_at_10.57.24.png)
![Screen_Shot_2017-06-08_at_11.04.07](/uploads/f94ef4686e8e065ee74c70f388735245/Screen_Shot_2017-06-08_at_11.04.07.png)
![Screen_Shot_2017-06-08_at_10.57.55](/uploads/6a280e347596ad17a50cea2f5f652ca1/Screen_Shot_2017-06-08_at_10.57.55.png)1.0username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/103Don't forget apps to be added2017-06-09T12:39:41Zusername-removed-124398Don't forget apps to be added1.0username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/102Show repo pagination only in app view2017-06-20T16:22:47Zusername-removed-124398Show repo pagination only in app view### Before
![Screen_Shot_2017-06-08_at_09.35.56](/uploads/bfcb6445ef4a1170fe6d95b91381bb8a/Screen_Shot_2017-06-08_at_09.35.56.png)
### Now
![Screen_Shot_2017-06-08_at_09.37.30](/uploads/7a3f01e7238fc4a6f29b7dd194d10777/Screen_Shot_201...### Before
![Screen_Shot_2017-06-08_at_09.35.56](/uploads/bfcb6445ef4a1170fe6d95b91381bb8a/Screen_Shot_2017-06-08_at_09.35.56.png)
### Now
![Screen_Shot_2017-06-08_at_09.37.30](/uploads/7a3f01e7238fc4a6f29b7dd194d10777/Screen_Shot_2017-06-08_at_09.37.30.png)1.0username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/101Beautify remove apk view2017-06-14T20:09:54Zusername-removed-124398Beautify remove apk viewA quick copy'n'paste from remove screenshot view. Main problem was that is wasn't centered.
### Before
![Screen_Shot_2017-06-08_at_09.33.06](/uploads/842b31866e8d51eb089263e08174cd0d/Screen_Shot_2017-06-08_at_09.33.06.png)
### Now
!...A quick copy'n'paste from remove screenshot view. Main problem was that is wasn't centered.
### Before
![Screen_Shot_2017-06-08_at_09.33.06](/uploads/842b31866e8d51eb089263e08174cd0d/Screen_Shot_2017-06-08_at_09.33.06.png)
### Now
![Screen_Shot_2017-06-08_at_09.32.49](/uploads/82440331ecc8d2088875f5354ea0bcc5/Screen_Shot_2017-06-08_at_09.32.49.png)1.0username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/100Beautify remove app view2017-06-14T20:09:55Zusername-removed-124398Beautify remove app viewA quick copy'n'paste from remove screenshot view.
### Before
![Screen_Shot_2017-06-08_at_09.28.08](/uploads/958bbfde206db8411e5d8e4cf5118574/Screen_Shot_2017-06-08_at_09.28.08.png)
### Now
![Screen_Shot_2017-06-08_at_09.26.57](/uploa...A quick copy'n'paste from remove screenshot view.
### Before
![Screen_Shot_2017-06-08_at_09.28.08](/uploads/958bbfde206db8411e5d8e4cf5118574/Screen_Shot_2017-06-08_at_09.28.08.png)
### Now
![Screen_Shot_2017-06-08_at_09.26.57](/uploads/cccd3de3f0f48ac139b99542f6b52248/Screen_Shot_2017-06-08_at_09.26.57.png)1.0username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/99Fix two JavaScript errors2017-06-14T20:09:55Zusername-removed-124398Fix two JavaScript errorsBecause the elements were hidden by Django and as such not available in the DOM,
JavaScript wasn't able to find them and throw NullPointerExceptions.
This is one of the stacktraces:
```js
TypeError: document.getElementById(...) is null
...Because the elements were hidden by Django and as such not available in the DOM,
JavaScript wasn't able to find them and throw NullPointerExceptions.
This is one of the stacktraces:
```js
TypeError: document.getElementById(...) is null
http://127.0.0.1:8000/repo/5/
Line 134
```
Fixes #100.1.0username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/98Upgrade python dependencies in setup.sh2017-06-14T20:09:56Zusername-removed-124398Upgrade python dependencies in setup.shMy fork's pipeline succeeded :smile: : https://gitlab.com/NicoAlt/repomaker/builds/18106452#down-build-trace
Reference: https://gitlab.com/fdroid/repomaker/merge_requests/91#note_31622916My fork's pipeline succeeded :smile: : https://gitlab.com/NicoAlt/repomaker/builds/18106452#down-build-trace
Reference: https://gitlab.com/fdroid/repomaker/merge_requests/91#note_31622916username-removed-26331username-removed-26331https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/97Only allow the user to add apps that do not exist in the repo2017-06-14T20:09:56Zusername-removed-26331Only allow the user to add apps that do not exist in the repoIf an app with the same package ID already exists in the repo,
it will still be shown, but the `Add` button will be disabled
and show `Added` instead.
Closes #93If an app with the same package ID already exists in the repo,
it will still be shown, but the `Add` button will be disabled
and show `Added` instead.
Closes #931.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/96Show release date of latest version on app cards2017-06-14T20:09:56Zusername-removed-26331Show release date of latest version on app cardsBefore the date of the last update to the app or its metadata was shown
Closes #106Before the date of the last update to the app or its metadata was shown
Closes #1061.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/95Remove empty <a> tags from app descriptions2017-06-14T20:09:57Zusername-removed-26331Remove empty <a> tags from app descriptionsThese empty links were caused by our HTML sanitizer
removing links with unsupported protocols,
but then leaving the empty link behind.
An additional filter that is run after sanitation fixes this.
Upstream ticket: https://github.com/mo...These empty links were caused by our HTML sanitizer
removing links with unsupported protocols,
but then leaving the empty link behind.
An additional filter that is run after sanitation fixes this.
Upstream ticket: https://github.com/mozilla/bleach/issues/288
Fixes #601.0username-removed-124398username-removed-124398https://staging.gitlab.com/fdroid/repomaker/-/merge_requests/94Use background task priorities2017-06-14T20:09:57Zusername-removed-26331Use background task prioritiesThe priorities of background tasks will be used
to give the repo update (and publish) task a lower priority,
so that all other tasks that still modify the repository get executed first.
This should also reduce the number of required upd...The priorities of background tasks will be used
to give the repo update (and publish) task a lower priority,
so that all other tasks that still modify the repository get executed first.
This should also reduce the number of required updates and publish tasks,
because before a new screenshot would be downloaded right after an
update and then trigger a new update.
Now all tasks that cause updates are executed before the actual update
happens, so only one update needs to be performed in the end.
This commit also lowers the priority of remote repo updates,
so that all other tasks are done first.
Closes #941.0username-removed-124398username-removed-124398