`--enable-feature` flag no longer works
Noticed this today when trying to run some tests with the --enable-feature gitaly_enforce_requests_limits
on. They now fail with the following:
$ gitlab-qa Test::Instance::$TARGET_ENVIRONMENT --enable-feature gitaly_enforce_requests_limits
/usr/local/bundle/gems/gitlab-qa-4.0.1/lib/gitlab/qa/release.rb:68:in `image': undefined method `[]' for nil:NilClass (NoMethodError)
from /usr/local/bundle/gems/gitlab-qa-4.0.1/lib/gitlab/qa/release.rb:101:in `dev_gitlab_org?'
from /usr/local/bundle/gems/gitlab-qa-4.0.1/lib/gitlab/qa/scenario/test/instance/deployment_base.rb:23:in `perform'
from /usr/local/bundle/gems/gitlab-qa-4.0.1/lib/gitlab/qa/scenario/template.rb:8:in `block in perform'
from /usr/local/bundle/gems/gitlab-qa-4.0.1/lib/gitlab/qa/scenario/template.rb:6:in `tap'
from /usr/local/bundle/gems/gitlab-qa-4.0.1/lib/gitlab/qa/scenario/template.rb:6:in `perform'
from /usr/local/bundle/gems/gitlab-qa-4.0.1/lib/gitlab/qa/runner.rb:41:in `run'
from /usr/local/bundle/gems/gitlab-qa-4.0.1/exe/gitlab-qa:8:in `<top (required)>'
from /usr/local/bundle/bin/gitlab-qa:23:in `load'
from /usr/local/bundle/bin/gitlab-qa:23:in `<main>'
I think this commit has changed the behaviour here with double dashes and it's causing it to think it's the rspec separator.
Edited by George Koltsov