Skip to content
Snippets Groups Projects
Commit b25c1d65 authored by Adrian Moisey's avatar Adrian Moisey
Browse files

Rename iter_review_comments to be compatiable with 1.0

parent bab14ba7
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -299,17 +299,6 @@ class PullRequest(GitHubCore):
url = self._build_url(base_url=self.links['comments'])
return self._iter(int(number), url, IssueComment, etag=etag)
 
def iter_review_comments(self, number=-1, etag=None):
r"""Iterate over the review comments on this pull request.
:param int number: (optional), number of comments to return. Default:
-1 returns all available comments.
:param str etag: (optional), ETag from a previous request to the same
endpoint
:returns: generator of :class:`ReviewComment <ReviewComment>`\ s
"""
url = self._build_url('comments', base_url=self._api)
return self._iter(int(number), url, ReviewComment, etag=etag)
@requires_auth
def merge(self, commit_message=''):
"""Merge this pull request.
Loading
Loading
@@ -340,6 +329,17 @@ class PullRequest(GitHubCore):
"""
return self.update(self.title, self.body, 'open')
 
def review_comments(self, number=-1, etag=None):
r"""Iterate over the review comments on this pull request.
:param int number: (optional), number of comments to return. Default:
-1 returns all available comments.
:param str etag: (optional), ETag from a previous request to the same
endpoint
:returns: generator of :class:`ReviewComment <ReviewComment>`\ s
"""
url = self._build_url('comments', base_url=self._api)
return self._iter(int(number), url, ReviewComment, etag=etag)
@requires_auth
def update(self, title=None, body=None, state=None):
"""Update this pull request.
Loading
Loading
Loading
Loading
@@ -42,6 +42,6 @@ class TestReviewComment(IntegrationHelper):
cassette_name = self.cassette_name('reply')
with self.recorder.use_cassette(cassette_name):
p = self.gh.pull_request('sigmavirus24', 'github3.py', 286)
c = next(p.iter_review_comments())
c = next(p.review_comments())
comment = c.reply('Replying to comments is fun.')
assert isinstance(comment, github3.pulls.ReviewComment)
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment