Merge branch 'an/2024-11-07-nominally-wanted-porpoise' into 'main'

fix: fix documentation, broken script

See merge request gitlab-com/gl-infra/common-ci-tasks!826

terraform-module-publish.md

@@ -8,10 +8,10 @@ include:
   # see https://gitlab.com/gitlab-com/gl-infra/common-ci-tasks/-/blob/main/terraform-module-publish.md
   - project: 'gitlab-com/gl-infra/common-ci-tasks'
     ref: v2.45.0  # renovate:managed
-    file: terraform-module-publish.md
+    file: terraform-module-publish.yml
     inputs:
-      module_name:
-      module_system:
+      module_name: # Defaults to project name
+      module_system: # aws,google,etc
 ```
 ## Excluding files from the Terraform Module
@@ -22,3 +22,15 @@ This will reduce the size of the module,
 improving performance throughout the development and provisioning cycle.
 Dot files, including `.git`, will also be excluded by default.
+
+### Example `.tfmoduleignore`
+
+This snippet demonstrates the format of `.tfmoduleignore`:
+
+```console
+$ cat .tfmoduleignore
+CODEOWNERS
+*.md
+renovate.json
+scripts/**
+```

terraform-module-publish.yml

@@ -29,7 +29,7 @@ spec:
 ---
 publish-terraform-module:
-  image: curlimages/curl:latest
+  image: registry.gitlab.com/gitlab-com/gl-infra/common-ci-tasks-images/terraform-module-publish:latest
   stage: release
   variables:
     TERRAFORM_MODULE_DIR: $[[ inputs.module_dir | expand_vars ]]
@@ -40,7 +40,7 @@ publish-terraform-module:
     - |
       # Sanitize version, remove `^v`
       TERRAFORM_MODULE_VERSION=${TERRAFORM_MODULE_VERSION#v}
-      TARBALL_FILE=${TERRAFORM_MODULE_NAME}-${TERRAFORM_MODULE_SYSTEM}-${TERRAFORM_MODULE_VERSION}.tgz
+      TARBALL_FILE=$(mktemp).tgz
       if [[ -f .tfmoduleignore ]]; then
         ignore_args="--exclude-from=.tfmoduleignore"
@@ -52,8 +52,9 @@ publish-terraform-module:
     - |
       tar -cvzf "${TARBALL_FILE}" \
         -C "${TERRAFORM_MODULE_DIR}" \
-        --exclude='*/\.*'
-        ${ignore_args}
+        --exclude='*/\.*' \
+        --exclude-vcs \
+        ${ignore_args} \
         .
     # Upload