Skip to content
Snippets Groups Projects
Unverified Commit ecf1a021 authored by Andrew Newdigate's avatar Andrew Newdigate
Browse files

chore: skip golangci-lint patch version renovate upgrades

golangci-lint cannot use truncated versions because pre-commit `rev`
versions don't match.

This reverts the truncated versions change for this dependency, and
switches to a strategy of ignoring patch versions.

This is a reasonable approach for golangci-lint as patch version
upgrades generally only cover dependency upgrades and minor issues, and
don't require Renovate MRs. In the case of a bug affecting the team, a
manual upgrade can be done. This is likely to be a a rare event, so on
balance will reduce workload for the team as much as truncated versions
would.
parent 2d3079f9
No related branches found
No related tags found
No related merge requests found
Pipeline #21994266 passed
Loading
Loading
@@ -153,6 +153,8 @@ In order for this to work effectively and safely, several conditions must be met
This is not the case for all dependencies, although it is the case for images published in the
[common-ci-tasks-images project](https://gitlab.com/gitlab-com/gl-infra/common-ci-tasks-images),
used by several of the tasks in this project.
1. If the dependency is used for `pre-commit`, the `pre-commit` `rev:` revision (normally a tag in the repo) must match
the truncated version too, otherwise it won't install when `pre-commit` runs.
1. Truncated versions only works with `mise`, since `asdf` does not support truncated versions.
1. Truncated versions should be avoided for runtime dependencies, where having greater control over the providence
of the produced artifacts is more important.
Loading
Loading
Loading
Loading
@@ -301,6 +301,16 @@
],
"groupName": "golangci-lint-{{updateType}}"
},
{
"description": "Skip golangci-lint patch dependencies to reduce noise",
"matchDepPatterns": [
"golangci-lint"
],
"matchUpdateTypes": [
"patch"
],
"enabled": false
},
{
"description": "Give Terraform upgrades some time to mature",
"matchDepPatterns": [
Loading
Loading
Loading
Loading
@@ -8,7 +8,6 @@
"gitlab-com/gl-infra/common-ci-tasks",
"mvdan/sh",
"koalaman/shellcheck",
"golangci/golangci-lint",
"gitlab.com/gitlab-com/gl-infra/jsonnet-tool"
],
"extractVersion": "^v?(?<version>\\d+\\.\\d+)"
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment