Possibly breaking change in omnibus-gitlab Container Registry configuration for 9.4.0
Who is affected?
All users who have configured omnibus-gitlab package to use non-bundled Container Registry using our docs.
Solution
Users need to specify registry['internal_key'] in their /etc/gitlab/gitlab.rb and run sudo gitlab-ctl reconfigure. Example of (related) configuration:
gitlab_rails['registry_key_path'] = "/custom/ppth/to/registry-key.key"
registry['internal_key'] = "ABCD\nEFGH\nIJKL="Who is unaffected
All users using our built in registry and our built in configuration. Also users who have registry['internal_key'] set.
Details
When fixing a bug with https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1738, we've inadvertently created an issue with users who were using our package to connect to external container registry. The fix was created with the intention of making required GitLab configuration independent from the configuration for the Registry. This fix allows the user to even run the Registry on a separate node from GitLab.
However, users have been using this flow which was not fully (correctly) documented and our docs update are running behind.
Next steps
- We will update the 9.4 release blog post https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/6880/diffs
- We are working on updating the docs and making them clearer: https://gitlab.com/gitlab-org/omnibus-gitlab/issues/2612
/cc @lbot
