Remove Disqus from Review Apps links

From this thread: https://gitlab.slack.com/archives/C03N3AY9W/p1503497530000402

Disqus bot is picking up the page title from the Review Apps link and sticks with it:

I ask myself which other bots are caching the review apps stuff.

Is there a way to remove Disqus from Review Apps links? There should be a config in Disqus control panel to enable/disable wildcard domains, maybe?

cc/ @cmattrex @connorshea @axil @rspeicher

added blog fix labels

It's not the Disqus bot that picks it up. When you create a review app with the Disqus javascript at the end of the page it "phones home" and registers the blog post using the available metadata (i.e. the title and the rest of it). When the metadata changes it doesn't update the record in their database, so we're left with the placeholder metadata.

In our Disqus admin console we have gitlab.com added as a trusted domain, which makes it include all subdomains as well. We could change it to just about.gitlab.com, but I'm not sure if it'll disable it from working on subdomains on the subdomain (e.g. review-app.about.gitlab.com).

Thanks @cmattrex :)

We could change it to just about.gitlab.com

I don't think this is the best approach, we might break things. And it's great to know that we have a wildcard for *.gitlab.com, so we can easily implement it on docs.gitlab.com

Yeah, that change is volatile. Other things might break. We have a separate site for specifically docs.gitlab.com. We could have one for about.gitlab.com as well.

Hmmmm... that sounds like a plan :)

We have a separate site for specifically docs.gitlab.com. do we?

Can you get me the snippet, I'll try to add them to the docs

Yup, we do. We're not using it, though. Here's the recommended snippet:

<div id="disqus_thread"></div>
<script>

/**
*  RECOMMENDED CONFIGURATION VARIABLES: EDIT AND UNCOMMENT THE SECTION BELOW TO INSERT DYNAMIC VALUES FROM YOUR PLATFORM OR CMS.
*  LEARN WHY DEFINING THESE VARIABLES IS IMPORTANT: https://disqus.com/admin/universalcode/#configuration-variables*/
/*
var disqus_config = function () {
this.page.url = PAGE_URL;  // Replace PAGE_URL with your page's canonical URL variable
this.page.identifier = PAGE_IDENTIFIER; // Replace PAGE_IDENTIFIER with your page's unique identifier variable
};
*/
(function() { // DON'T EDIT BELOW THIS LINE
var d = document, s = d.createElement('script');
s.src = 'https://gitlab-docs.disqus.com/embed.js';
s.setAttribute('data-timestamp', +new Date());
(d.head || d.body).appendChild(s);
})();
</script>
<noscript>Please enable JavaScript to view the <a href="https://disqus.com/?ref_noscript">comments powered by Disqus.</a></noscript>

I'd be more comfortable if some of the other Disqus admins made the changes for about.gitlab.com since they're pretty hard-hitting and I'm not to confident with my Disqus admin-fu.

mentioned in issue gitlab-docs#44 (closed)

Thanks @cmattrex let's track the implementation for the docs here: https://gitlab.com/gitlab-com/gitlab-docs/issues/44

@cmattrex

I'd be more comfortable if some of the other Disqus admins made the changes for about.gitlab.com since they're pretty hard-hitting and I'm not to confident with my Disqus admin-fu.

Yes, let's see what Axil and Robert will say about it as well. ;) Thanks again!

mentioned in merge request !6226 (merged)

Ok, this is the MR I tried to hack this around, but didn't have the time to investigate and finish it https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/6226.

assigned to @axil

changed milestone to %10.0

closed via merge request !6226 (merged)

mentioned in commit 5b3ae69e