Show blog post comments only in production
Fixes https://gitlab.com/gitlab-com/www-gitlab-com/issues/1611
This MR actually sets an environment variable only when the stage is production
.
Middleman then checks this and skips the addition of the disqus snippet from the layout
if the criteria is not met.
Merge request reports
Activity
mentioned in issue #1611 (closed)
@rspeicher would you mind reviewing it for us?
added SEO label
assigned to @rspeicher
cc/ @connorshea fyi ;)
- Resolved by Achilleas Pipinellis
@axil Cool solution, just one suggestion to reduce some duplication.
assigned to @axil
added 3183 commits
-
749ea894...e489fe1d - 3182 commits from branch
master
- 258834d6 - Show blog post comments only in production
-
749ea894...e489fe1d - 3182 commits from branch
@rspeicher thanks for the suggestion :) Assigning to you. Let's see how the review app behaves, I tested locally with:
MIDDLEMAN_ENV=production middleman
and
middleman
and it worked as expected.
Seems what I came across in https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/6226#note_31117870 is no longer the issue.
Edited by Achilleas Pipinellisassigned to @rspeicher
- Resolved by Achilleas Pipinellis
@axil One style thing!
assigned to @axil
assigned to @rspeicher
enabled an automatic merge when the pipeline for ad6c1796 succeeds
changed milestone to %10.0
mentioned in commit 5b3ae69e