Skip to content
Snippets Groups Projects

Show blog post comments only in production

Merged Achilleas Pipinellis requested to merge ignore-comments-unless-prod into master
All threads resolved!

Fixes https://gitlab.com/gitlab-com/www-gitlab-com/issues/1611

This MR actually sets an environment variable only when the stage is production. Middleman then checks this and skips the addition of the disqus snippet from the layout if the criteria is not met.

Edited by Achilleas Pipinellis

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @axil Cool solution, just one suggestion to reduce some duplication. :thumbsup:

  • assigned to @axil

  • Achilleas Pipinellis added 3183 commits

    added 3183 commits

    • 749ea894...e489fe1d - 3182 commits from branch master
    • 258834d6 - Show blog post comments only in production

    Compare with previous version

  • Achilleas Pipinellis unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Achilleas Pipinellis resolved all discussions

    resolved all discussions

  • Author Maintainer

    @rspeicher thanks for the suggestion :) Assigning to you. Let's see how the review app behaves, I tested locally with:

    MIDDLEMAN_ENV=production middleman

    and

    middleman

    and it worked as expected.

    Seems what I came across in https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/6226#note_31117870 is no longer the issue.

    Edited by Achilleas Pipinellis
  • @axil One style thing!

  • assigned to @axil

  • Achilleas Pipinellis resolved all discussions

    resolved all discussions

  • added 1 commit

    • ad6c1796 - Show blog post comments only in production

    Compare with previous version

  • Robert Speicher enabled an automatic merge when the pipeline for ad6c1796 succeeds

    enabled an automatic merge when the pipeline for ad6c1796 succeeds

  • Achilleas Pipinellis changed milestone to %10.0

    changed milestone to %10.0

  • Robert Speicher mentioned in commit 5b3ae69e

    mentioned in commit 5b3ae69e

  • Please register or sign in to reply
    Loading