Skip to content
Snippets Groups Projects
Zeger-Jan van de Weg's avatar
deleted branch zj-contributing at GitLab.org / Dockerfile
Zeger-Jan van de Weg's avatar
accepted merge request !20 "Update contributing guidelines" at GitLab.org / Dockerfile
Zeger-Jan van de Weg's avatar
pushed to branch master at GitLab.org / Dockerfile
Zeger-Jan van de Weg's avatar
opened merge request !20 "Update contributing guidelines" at GitLab.org / Dockerfile
Zeger-Jan van de Weg's avatar
pushed new branch zj-contributing at GitLab.org / Dockerfile
🚄 Job van der Voort 🚀's avatar
opened milestone %9.6 in GitLab.org / Dockerfile
Mark Pundsack's avatar
Zeger-Jan van de Weg's avatar
accepted merge request !14 "Use multi-stage docker builds for Golang.Dockerfile" at GitLab.org / Dockerfile
Zeger-Jan van de Weg's avatar
pushed to branch master at GitLab.org / Dockerfile
Zeger-Jan van de Weg's avatar
commented on merge request !16 "Use multi-stage docker builds for Golang-scratch.Dockerfile" at GitLab.org / Dockerfile

Because we have to wait for a 3rd party?

Mark Pundsack's avatar
commented on merge request !16 "Use multi-stage docker builds for Golang-scratch.Dockerfile" at GitLab.org / Dockerfile

@zj Why WIP?

Mark Pundsack's avatar
commented on merge request !17 "Add Binary.Dockefile" at GitLab.org / Dockerfile

Possibly. I was using the same base as others use, and didn't investigate if there was something else better.

Zeger-Jan van de Weg's avatar
commented on merge request !17 "Add Binary.Dockefile" at GitLab.org / Dockerfile

This seems counter productive

Mark Pundsack's avatar
opened merge request !17 "Add Binary.Dockefile" at GitLab.org / Dockerfile
Mark Pundsack's avatar
pushed new branch Binary-scratch at GitLab.org / Dockerfile
Mark Pundsack's avatar
pushed new branch Binary-alpine at GitLab.org / Dockerfile
Mark Pundsack's avatar
commented on merge request !14 "Use multi-stage docker builds for Golang.Dockerfile" at GitLab.org / Dockerfile

Tested with https://gitlab.com/markpundsack/go-hello-world/container_registry and it works fine on GitLab.com....

Mark Pundsack's avatar
commented on merge request !14 "Use multi-stage docker builds for Golang.Dockerfile" at GitLab.org / Dockerfile

Apparently multi-stage support is in Docker 17.05, which is what latest docker:dind has!

Mark Pundsack's avatar
commented on merge request !16 "Use multi-stage docker builds for Golang-scratch.Dockerfile" at GitLab.org / Dockerfile

Inspired by http://blog.alexellis.io/mutli-stage-docker-builds/.

Mark Pundsack's avatar
commented on merge request !14 "Use multi-stage docker builds for Golang.Dockerfile" at GitLab.org / Dockerfile

Maybe the final build image of all three of these MRs should be based on scratch?