unlink of non-existing log file is now a warning only

Closes #144

logrotate.c

@@ -98,8 +98,6 @@ static time_t nowSecs = 0;
 static uid_t save_euid;
 static gid_t save_egid;
-static int shred_file(int fd, char *filename, struct logInfo *log);
-
 static int globerr(const char *pathname, int theerr)
 {
     message(MESS_ERROR, "error accessing %s: %s\n", pathname,
@@ -585,7 +583,7 @@ static int shred_file(int fd, char *filename, struct logInfo *log)
 	}
 	if (!(log->flags & LOG_FLAG_SHRED)) {
-		return unlink(filename);
+		goto unlink_file;
 	}
 	message(MESS_DEBUG, "Using shred to remove the file %s\n", filename);
@@ -628,7 +626,17 @@ static int shred_file(int fd, char *filename, struct logInfo *log)
 	/* We have to unlink it after shred anyway,
 	 * because it doesn't remove the file itself */
-	return unlink(filename);
+
+unlink_file:
+	if (unlink(filename) == 0)
+		return 0;
+	if (errno != ENOENT)
+		return 1;
+
+	/* unlink of log file that no longer exists is not a fatal error */
+	message(MESS_ERROR, "error unlinking log file %s: %s\n", filename,
+			strerror(errno));
+	return 0;
 }
 static int removeLogFile(char *name, struct logInfo *log)

test/Makefile.am

@@ -72,6 +72,7 @@ TEST_CASES = \
 	test-0071.sh \
 	test-0072.sh \
 	test-0073.sh \
+	test-0074.sh \
 	test-0100.sh \
 	test-0101.sh

test/test-0074.sh

+#!/bin/bash
+
+. ./test-common.sh
+
+cleanup 74
+
+# ------------------------------- Test 74 ------------------------------------
+# unlink of log file that no longer exists should be handled as a warning only
+# https://github.com/logrotate/logrotate/issues/144
+preptest test.log 74 1
+
+$RLR test-config.74 --verbose
+
+checkoutput <<EOF
+test.log 0
+test.log.1 0 zero
+EOF

test/test-config.74.in

+&DIR&/test.log {
+    create
+    rotate 1
+    size 0
+    postrotate
+        rm -fv &DIR&/test.log.2
+    endscript
+}