- make distribution tarballs report logrotate version properly
  [RHBZ#1500264](https://bugzilla.redhat.com/1500264)
- make ```(un)compress work``` even if stdin and/or stdout are closed (#154)
- remove ```-s``` from ```DEFAULT_MAIL_COMMAND``` and improve its documenation (#152)
- uncompress logs before mailing them even if ```delaycompress``` is enabled (#151)
- handle unlink of a non-existing log file as a warning only (#144)
- include compile-time options in the output of ```logrotate --version``` (#145)
- make ```logrotate --version``` print to stdout instead of stderr (#145)
- flush write buffers before syncing state file (#148)
- specify (un)compress utility explicitly in tests (#137)
- enable running tests in parallel (#132)
- explicitly map root UID/GID to 0 on Cygwin (#133)
- add ```.dpkg-bak``` and ```.dpkg-del``` to default tabooext list (#134)

This was supposed to be fixed by 3.12.3-21-g8523cb3 but it was not
because there was a typo sizeof(sizeof ...) and even after fixing
the typo it referred to the pointer size, instead of struct size.

Luckily, this was detected by Clang analyzer again.  Now I verified
that the defect goes away with this commit:

FIXED DEFECTS
=============
Error: CLANG_WARNING:
logrotate.c:249:15: warning: Result of 'malloc' is converted to a pointer of type 'struct logStateList', which is incompatible with sizeof operand type 'unsigned long'

Since commit 3.11.0-36-g8612d1c logrotate reported UNKNOWN version
in case someone ran autoreconf in the directory extracted out of the
tarball produced by 'make dist'.

This commit makes autoreconf pick the version string from the suffix
of the directory where build-aux/git-version-gen runs (usually the
top-level directory).  This works reliably for sources extracted out
of the tarballs produced by 'make dist'.

Bug: https://bugzilla.redhat.com/1500264

Closes #154

Closes #152

Closes #152

... even if delaycompress is enabled

Closes #151

Closes #144

example output:

$ logrotate --version
logrotate 3.12.3

    Default mail command:       /bin/mail
    Default compress command:   /bin/gzip
    Default uncompress command: /bin/gunzip
    Default compress extension: .gz
    Default state file path:    /var/lib/logrotate.status
    ACL support:                yes
    SELinux support:            yes

Closes #145

Closes #145

found by clang's scan-build

Closes #149

use a more distinct name in relation to struct logState

Closes #149

Piping ls output to egrep in subshell is over the top difficult way to
achieve what can be done with a simple regular expression.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

Closes #138

SC2069: The order of the 2>&1 and the redirect matters.  The 2>&1 has to be
last.

Maintainer propsed stderr should be visible, see review link for details.

Reference; https://github.com/koalaman/shellcheck/wiki/SC2069
Review: https://github.com/logrotate/logrotate/pull/138


Signed-off-by: Sami Kerola <kerolasa@iki.fi>

Closes #138

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

Closes #138

The myhost.org is real domain.  It is better to use invalid. TLD that is
reserved by IETF to this purpose.

Reference: https://tools.ietf.org/html/rfc6761


Signed-off-by: Sami Kerola <kerolasa@iki.fi>

Closes #138

log.c: In function ‘log_once’:
log.c:52:2: warning: function ‘log_once’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
  vfprintf(where, format, args);
  ^~~~~~~~
  CC       logrotate.o
logrotate.c: In function ‘prerotateSingleLog’:
logrotate.c:1584:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
      for (glob_count = 0; glob_count < globResult.gl_pathc; glob_count++) {
                                      ^
logrotate.c:1586:33: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       if (((globResult.gl_pathc >= rotateCount) && (glob_count <= (globResult.gl_pathc - rotateCount)))
                                 ^~
logrotate.c:1586:64: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       if (((globResult.gl_pathc >= rotateCount) && (glob_count <= (globResult.gl_pathc - rotateCount)))
                                                                ^~
logrotate.c:1432:9: warning: this statement may fall through [-Wimplicit-fallthrough=]
       j += 10; /* strlen("[0-9][0-9]") */
       ~~^~~~~
logrotate.c:1433:6: note: here
      case 'm':
      ^~~~

logrotate.c: In function ‘compGlobResult’:
logrotate.c:119: error: declaration of ‘time’ shadows a global declaration
/usr/include/time.h:186: error: shadowed declaration is here

Closes #147

Flush the libc buffers before calling fsync().

Otherwise the file content may not yet have been written to the kernel,
and fsync() will not help in ensuring that the file data is written to
disk.

Closes #148

Closes #139

... to prevent test failures if a custom compression utility is set
using the --with-compress-command, --with-uncompress-command, and
--with-compress-extension build-time options.

Closes #137

Closes #132

Closes #132

Closes #132

Closes #132

Closes #132

Closes #132

Closes #132

Closes #133

... factored out of readModeUidGid().  No change in behavior intended.

See https://bugs.debian.org/716649

- copy and copytruncate directives now work together again
- unlink() is no longer preceded by open() unless shred is enabled (#124)
- compress and uncompress now take commands from $PATH, too (#122)

This commit fixes a regression introduced
by 3b26f4d8.

Closes #125

Alphabetical order helps users to read what is in the list.  In config.c
horizontal list is converted to vertical to allow version control to track
each extension separately.  Vertical ordered lists are also easy to cross
check, and indeed that helped noticing manual page had missed ,v extension
that was probably added to avoid RCS files being mangled by the logrotate.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

Closes #126

Closes #124

The execlp/execvp calls that execute them search for executables
in $PATH, which access(..., X_OK) does not support.  This commit
makes it possible to specify the (un)compress commands by their
base name only in case they are available in $PATH.

Closes #122

- build fixes related to -Werror (#119) and -Werror=format= (#108)
- 'configure --enable-werror' now controls use of -Werror (#123)