Please pay special attention to this commit as I mostly react to my
own comments (while also trying to incorporate results from wider
discussions).

In approximate order if importance:

- As per discussion, I made acceptance of new team mebers depend on a
  supermajority vote (while given special emphasis on the desire to
  reach consensus).

- As per discussion, I made maintainership independent from team
  membership, albeit explicitly called out as an exception. (I also
  mentioned the possible graduation path in the FAQ to illustrate how
  such an exception could look like.)

- Changes in maintainership are now by lazy consensus, but have to be
  announced on the dev list. That saves us the explicit mention of a
  conflict-resolving vote, as that's part of our definition of lazy
  consensus. Thanks to maintainership being independent from team
  membership, everything a rogue maintainer has done, can be reverted,
  so there is no need to become any more formal about changes in
  maintainership.

- Clarified that there are no “abstain” votes (which is relevant for
  the multi-option votes to determine majority).

- Fixed “at least half the votes” to “more than half”.

- Numerous typography (mostly Oxford comma and “proper quotes”) and
  spelling fixes (mostly favour -> favor, as we in general use
  American spelling).

https://github.com/prometheus/prometheus/pull/2930#discussion_r155259186

This reverts commit 1a213c21.

after [more
discussion](https://github.com/prometheus/prometheus/pull/2930#discussion_r155288315)
we want to keep it as it was before.

dedup out of the individual vote sections, preserving the "should be
stated in email" clause.

than code contribution

use "lazy consensus" where appropriate. Address misc other comments.

it does not really reflect the practice, and the practice is
"maintainers decide" which does not need a separate statement.

this is a better explanation and doesn't come with a huge "abandoned
project" banner at the top.

- personnel matters are private
- so are finances.

replace all uses (except in the definition) of "repository" with
"project". Remove the duplicate "new projects" section, it is covered by
the generic projects one.

If the original maintainer consents, they can initiate the change
themselves anyway.

and where.

for consistency. Markdown should render this the same, I think.

specifically, change that the discussion should take place publicly.

this is (mostly) the result of discussion on the Prometheus Team mailing list and
in calls. Some parts were not quite clear from that, so I fleshed those
out as best as I could.

Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>

Add _test.go suffix to promql/bench.go, split test.go in to two.

Add _test.go suffix to promql/{bench.go, test.go} to prevent importing the testing package in a normal binary.

Log the stopping of TargetManager in Info

Fixes #2715

Signed-off-by: Goutham Veeramachaneni <cs14btech11014@iith.ac.in>

Make sure rendering config produces valid config

Fixes #2899

Signed-off-by: Goutham Veeramachaneni <goutham@boomerangcommerce.com>

Remote queue manager: Fix typo

Change 'send' to 'sent'.

Add a colorScheme parameter to PromConsole.Graph, to allow using custom colors in console graphs.

Marathon SD: Set port index label

The changes [1][] to Marathon service discovery to support multiple
ports mean that Prometheus now attempts to scrape all ports belonging to
a Marathon service.

You can use port definition or port mapping labels to filter out which
ports to scrape but that requires service owners to update their
Marathon configuration.

To allow for a smoother migration path, add a
`__meta_marathon_port_index` label, whose value is set to the port's
sequential index integer. For example, PORT0 has the value `0`, PORT1
has the value `1`, and so on.

This allows you to support scraping both the first available port (the
previous behaviour) in addition to ports with a `metrics` label.

For example, here's the relabel configuration we might use with
this patch:

    - action: keep
      source_labels: ['__meta_marathon_port_definition_label_metrics', '__meta_marathon_port_mapping_label_metrics', '__meta_marathon_port_index']
      # Keep if port mapping or definition has a 'metrics' label with any
      # non-empty value, or if no 'metrics' port label exists but this is the
      # service's first available port
      regex: ([^;]+;;[^;]+|;[^;]+;[^;]+|;;0)

This assumes that the Marathon API returns the ports in sorted order
(matching PORT0, PORT1, etc), which it appears that it does.

[1]: https://github.com/prometheus/prometheus/pull/2506

Fixes #2827.

Check for invalid utf-8 in lexer strings.

This protects against invalid utf-8 sneaking
in via label_replace.

Replace OptionalArgs int with Variadic int.

Check target labels are valid. Check for address after relabelling.