Skip to content
Snippets Groups Projects
  1. Dec 21, 2017
  2. Dec 19, 2017
  3. Dec 18, 2017
  4. Dec 17, 2017
  5. Dec 14, 2017
  6. Dec 13, 2017
  7. Dec 12, 2017
    • Luke Overend's avatar
      Pass ams to go routine when sending alerts (#3284) · 9532c2c7
      Luke Overend authored
      Currently when sending alerts via the go routine within `sendAll`, the value
      of `ams` is not passed to the routine, causing it to use the updated value of `ams`.
      
      Example config:
      
      ```
      alerting:
        alertmanagers:
          - basic_auth:
              username: 'prometheus'
              password: 'test123'
            static_configs:
            - targets:
              - localhost:9094
          - static_configs:
            - targets:
              - localhost:9095
      ```
      
      In this example alerts sent to `localhost:9094` fail with:
      
      ```
      level=error ts=2017-10-12T10:03:53.456819948Z caller=notifier.go:445
      component=notifier alertmanager=http://localhost:9094/api/v1/alerts
      count=1 msg="Error sending alert" err="bad response status 401
      Unauthorized"
      ```
      
      If you change the order to be:
      
      ```
      alerting:
        alertmanagers:
          - static_configs:
            - targets:
              - localhost:9095
          - basic_auth:
              username: 'prometheus'
              password: 'test123'
            static_configs:
            - targets:
              - localhost:9094
      ```
      
      It works as expected.
      
      This commit changes the behavour so `ams` is passed to the go routine so
      `n.sendOne` uses the appropriate `http.Client` details.
      9532c2c7
    • Goutham Veeramachaneni's avatar
      Merge pull request #3570 from Gouthamve/colon-snapshot · 2d73d2b8
      Goutham Veeramachaneni authored
      Make the date returned by snapshot script friendly
      Unverified
      2d73d2b8
  8. Dec 11, 2017
Loading