Merge branch 'feature-disable-backup' into 'master'

Feature disable backup

This MR permits the user to disable backup cron task even if environment is `production`.

See merge request !111

attributes/default.rb

@@ -269,6 +269,7 @@ default['gitlab']['monitrc']['emergency_email'] = nil
 default['gitlab']['monitrc']['emergency_events'] = ['timeout']
 # backups
+default['gitlab']['backup']['enable'] = true
 default['gitlab']['backup']['cron']['action'] = :create
 default['gitlab']['backup']['cron']['minute'] = 0
 default['gitlab']['backup']['cron']['hour'] = 2

recipes/backup.rb

@@ -15,5 +15,5 @@ cron 'gitlab_backups' do
   path node['gitlab']['backup']['cron']['path']
   command "cd #{gitlab['home']}/gitlab && bundle exec rake gitlab:backup:create RAILS_ENV=#{gitlab['env']}"
-  only_if { gitlab['env'] == 'production' }
+  only_if { gitlab['backup']['enable'] and gitlab['env'] == 'production' }
 end

spec/backup_spec.rb

@@ -22,6 +22,18 @@ describe "gitlab::backup" do
           path: '/usr/local/bin:/usr/bin:/bin')
       end
+      describe "when backup disabled" do
+        let(:chef_run) do
+          runner = ChefSpec::Runner.new(platform: "ubuntu", version: version)
+          runner.node.set['gitlab']['backup']['enable'] = false
+          runner.converge("gitlab::backup")
+        end
+
+        it "does not create a cron job" do
+          expect(chef_run).to_not create_cron('gitlab_backups')
+        end
+      end
+
       describe "when in development environment" do
         let(:chef_run) do
           runner = ChefSpec::Runner.new(platform: "ubuntu", version: version)
@@ -53,6 +65,18 @@ describe "gitlab::backup" do
           path: '/usr/local/bin:/usr/bin:/bin')
       end
+      describe "when backup disabled" do
+        let(:chef_run) do
+          runner = ChefSpec::Runner.new(platform: "centos", version: version)
+          runner.node.set['gitlab']['backup']['enable'] = false
+          runner.converge("gitlab::backup")
+        end
+
+        it "does not create a cron job" do
+          expect(chef_run).to_not create_cron('gitlab_backups')
+        end
+      end
+
       describe "when in development environment" do
         let(:chef_run) do
           runner = ChefSpec::Runner.new(platform: "centos", version: version)