Add support for git -c parameters to git-upload-pack

Relates to gitaly#407 (closed) and gitaly!242 (merged)

assigned to @jacobvosmaer-gitlab

mentioned in merge request gitaly!242 (merged)

assigned to @stanhu

mentioned in issue gitlab-shell#98

changed title from Add GIT_CONFIG_PARAMETERS support to git-upload-pack to Add support for git -c parameters to git-upload-pack

assigned to @jacobvosmaer-gitlab

resolved all discussions

changed the description

merged

@jacobvosmaer-gitlab Thanks! Would you mind releasing a new version of gitaly-proto?

It appears in gitlab-shell we execute a gitaly-upload-pack binary and pass arguments in serialized JSON form, but this is what we have to do to make repeated bytes work in this form (https://stackoverflow.com/a/20105590/1992201):

$ ./go_build/bin/gitaly-upload-pack foo '{"repository":{"relative_path":"gitlab-ci.git","storage_name":"default"},"gl_repository":"project-1","gl_id":"key-148","git_config_parameters":[[123, 123], [124]]}

I just put dummy values at the end to demonstrate that unmarshalling byte arrays is less than ideal. We can do it, but is it worth the trouble?

For this reason, I propose we just change this to repeated string. Thoughts?