accepted
merge request
!91
"Add proto messages for RepositoryService.HasLocalBranches"
at
GitLab.org / gitaly-proto
-
b26708aa · Merge branch 'has-local-branch' into 'master'
- ... and 1 more commit. Compare 8ac6c4c6...b26708aa
commented on
merge request !91
"Add proto messages for RepositoryService.HasLocalBranches"
at
GitLab.org / gitaly-proto
Oh! Thanks @bkc
commented on
merge request !91
"Add proto messages for RepositoryService.HasLocalBranches"
at
GitLab.org / gitaly-proto
@eReGeBe Ahmad is off today (friday) so maybe reassign to someone else? :)
commented on
merge request !91
"Add proto messages for RepositoryService.HasLocalBranches"
at
GitLab.org / gitaly-proto
LGTM
opened
merge request
!91
"Add proto messages for RepositoryService.HasLocalBranches"
at
GitLab.org / gitaly-proto
I second removing the suffix. We don't have to drop GetBlob right away; we can change BlobService#get_blob to use this new call and deprecate the o...
right, missed that :)
Wouldn't renaming an endpoint give us backwards compatibility problems? If not, I'm ok with a rename. In any case, I vote to drop the BySHAs suffix.
If I understand correctly there's going to be: a "header" response message with size and oid, followed by one or more "body" response messages with...
IDK, I agree that BySHAs seems superflourous. Though IMO we should just change GetBlob => GetBlobs and have it take repeated bytes oid instead and ...