Skip to content
Snippets Groups Projects
New issue look: Off

Conversation CreateBranch and DeleteBranch

    • Open Issue created by Jacob Vosmaer (GitLab) @jacobvosmaer-gitlab

    Feature Flags: gitaly_delete_branch, gitaly_create_branch

    Stages:

    RPC Endpoints:

    • RefService::CreateBranch
    • RefService::DeleteBranch

    Known Client Routes:

    • Known client endpoints

    https://gitlab.com/gitlab-org/gitlab-ce/blob/133c72ae421b97f483417d5c427721336719b5da/lib/gitlab/git/repository.rb#L576-593

    We should use gitaly-ruby because we don't know if/how call sites rely on Rugged's custom branch name resolution.

    service RefService
  rpc CreateBranch(CreateBranchRequest) returns (CreateBranchResponse) {}
  rpc DeleteBranch(DeleteBranchRequest) returns (DeleteBranchResponse) {}

message CreateBranchRequest {
  Repository repository = 1;
  bytes name = 2;
  bytes start_point = 3;
}

CreateBranchResponse {
  enum Status {
    OK = 0;
    ERR_EXISTS = 1;
    ERR_INVALID_START_POINT = 2;
  }
  Status status = 1;
  Branch branch = 2;
}

// Branch should go in shared.proto
message Branch {
  bytes name = 1;
  GitCommit target_commit = 2;
}

message DeleteBranchRequest {
  Repository repository = 1;
  bytes name = 2;
}

// Not clear if we need to do status signaling; we can add fields later.
message DeleteBranchResponse {}
    3 of 4 checklist items completed · Edited by Andrew Newdigate
    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items ...

    • Activity

    Please register or sign in to reply