Handle multiple apps
Makes:
- production app use
url: http://$CI_PROJECT_NAME.$KUBE_DOMAIN
- staging app use
url: http://$CI_PROJECT_NAME-staging.$KUBE_DOMAIN
- review apps use
url: http://$CI_PROJECT_NAME-$CI_ENVIRONMENT_SLUG.$KUBE_DOMAIN
Also uses $CI_BUILD_REF_SLUG
in environment name instead of $CI_BUILD_REF_NAME
, which may have odd characters (including more slashes).
e.g. foo.example.com
, foo-staging.com
, and foo-27193-handle-4f99a2.example.com
Merge request reports
Activity
@ayufan Man, the documentation for
$CI_ENVIRONMENT_SLUG
is really unclear. How many characters does it truncate to? I thought it was 24 characters, but the example showshttps://100-do-the-4f99a2.example.com
, which is only 17 characters. Does it really strip outreview/
?And I really wonder if we should use
http://$CI_PROJECT_NAME-$CI_BUILD_REF_SLUG.$KUBE_DOMAIN
instead since the URL has less character limits.@ayufan Can
environment.url
reference a variable declared invariables
? Because I don't like repeating the URL in both places.assigned to @markpundsack
assigned to @zj
- Resolved by Zeger-Jan van de Weg
assigned to @markpundsack
added 7 commits
- 07518aa7...377fcb81 - 6 commits from branch
master
- fee771b0 - Handle multiple apps
- 07518aa7...377fcb81 - 6 commits from branch
@markpundsack I was renaming the rest anyway, to keep that up to date, so updated this too. It looked good to me, so I'm just going to merge this.
mentioned in commit 054bf206