Don't send notifications for jobs with allow_failure set

CHANGELOG

 v7.13.1
   - Fix: user could steal specific runner
+  - Fix: don't send notifications for jobs with allow_failure set
 v7.13.0
   - Allow to specify image and services in yml that can be used with docker

app/models/project_services/hip_chat_service.rb

@@ -44,6 +44,8 @@ class HipChatService < Service
   end
   def execute build
+    return if build.allow_failure?
+
     commit = build.commit
     return unless commit
     return unless commit.builds_without_retry.include? build

app/models/project_services/mail_service.rb

@@ -58,6 +58,8 @@ class MailService < Service
   end
   def execute(build)
+    return if build.allow_failure?
+
     # it doesn't make sense to send emails for retried builds
     commit = build.commit
     return unless commit

app/models/project_services/slack_message.rb

@@ -22,6 +22,7 @@ class SlackMessage
     if commit.matrix?
       commit.builds_without_retry.each do |build|
+        next if build.allow_failure?
         next unless build.failed?
         fields << {
           title: build.name,

app/models/project_services/slack_service.rb

@@ -57,6 +57,8 @@ class SlackService < Service
   end
   def execute(build)
+    return if build.allow_failure?
+
     commit = build.commit
     return unless commit
     return unless commit.builds_without_retry.include?(build)