Merge branch 'query_string_in_nwtwork' into 'master'

Make Network class to follow HTTP RFC

https://gitlab.com/gitlab-org/gitlab-ci/issues/144

See merge request !86

app/models/network.rb

@@ -7,7 +7,7 @@ class Network
   def authenticate(api_opts)
     opts = {
-      body: api_opts.to_json
+      query: api_opts
     }
     endpoint = File.join(url, API_PREFIX, 'user')

spec/requests/api/forks_spec.rb

@@ -5,13 +5,7 @@ describe API::API do
   let(:project) { FactoryGirl.create(:project) }
   let(:gitlab_url) { GitlabCi.config.gitlab_server.url }
-  let(:auth_opts) {
-    {
-      email: "test@test.com",
-      password: "123456"
-    }
-  }
-  let(:private_token) { Network.new.authenticate(auth_opts)["private_token"] }
+  let(:private_token) { Network.new.authenticate(access_token: "some_token")["private_token"] }
   let(:options) {
     {

spec/requests/api/projects_spec.rb

@@ -4,13 +4,7 @@ describe API::API do
   include ApiHelpers
   let(:gitlab_url) { GitlabCi.config.gitlab_server.url }
-  let(:auth_opts) {
-    {
-      email: "test@test.com",
-      password: "123456"
-    }
-  }
-  let(:private_token) { Network.new.authenticate(auth_opts)["private_token"] }
+  let(:private_token) { Network.new.authenticate(access_token: "some_token")["private_token"] }
   let(:options) {
     {

spec/requests/api/runners_spec.rb

@@ -10,14 +10,7 @@ describe API::API do
   describe "GET /runners" do
     let(:gitlab_url) { GitlabCi.config.gitlab_server.url }
-    let(:auth_opts) {
-      {
-        :email => "test@test.com",
-        :password => "123456"
-      }
-    }
-
-    let(:private_token) { Network.new.authenticate(auth_opts)["private_token"] }
+    let(:private_token) { Network.new.authenticate(access_token: "some_token")["private_token"] }
     let(:options) {
       {
         :private_token => private_token,

spec/support/stub_gitlab_calls.rb

@@ -40,7 +40,7 @@ module StubGitlabCalls
   def stub_oauth_user
     f = File.read(Rails.root.join('spec/support/gitlab_stubs/user.json'))
-    stub_request(:get, "#{gitlab_url}api/v3/user").
+    stub_request(:get, "#{gitlab_url}api/v3/user?access_token=some_token").
       with(:headers => {'Content-Type'=>'application/json'}).
       to_return(:status => 200, :body => f, :headers => {'Content-Type'=>'application/json'})
   end