Skip to content
Snippets Groups Projects
  1. Aug 30, 2015
  2. Jul 08, 2015
  3. Jun 29, 2015
  4. Jun 12, 2015
  5. Jun 03, 2015
  6. May 01, 2015
    • Howard P. Logsdon's avatar
      Fix notification issues on HipChatService, add HipChatMessage specs · f2e65ba1
      Howard P. Logsdon authored
      adding specs for HipChatMessage exposed some issues with the way I was
      building the matrix-commit style notification message, so it ended up being
      quite a bit more changes than I expected.
      
      The save call from the service configure form submits an empty string as
      the server URL if left blank, which I've indicated to do in order to use
      the default server, but Hash#merge will happily overwrite a full string with
      a blank string if asked, so we need to break that out, along with the worker
      options which get mutated into string hash keys, of which the HipChat client
      seems to not understand. Additionally, add another spec to make sure we call
      the Sidekiq worker with expected arguments.
      f2e65ba1
Loading