gdk update fails on gitaly

I just updated GDK to the latest gem version, pulled master, ran gdk update, and encountered this error:

cd gitaly/src/gitlab.com/gitlab-org/gitaly && \
        git stash && git checkout master && \
        git pull --ff-only
/bin/sh: 1: cd: can't cd to gitaly/src/gitlab.com/gitlab-org/gitaly
Makefile:122: recipe for target 'gitaly/.git/pull' failed
make: *** [gitaly/.git/pull] Error 2

I still get the same error after cloning Gitaly manually from https://gitlab.com/gitlab-org/gitaly to ./gitaly, there's no src directory in there so I'm not sure if gitlab_clone_dir in the Makefile is correct.

gdk run still works so this is just a minor issue.

@toupeira Thanks for the report! We will take a look at this. /cc @jacobvosmaer-gitlab

Maybe that gitaly update task should depend on whatever the gitaly install task is.

@ahmadsherif maybe you can look at this?

Edit: No wait that makes no sense. This is GDK-specific, not Gitaly-specific.

Looks like this is pretty broken in the Makefile right now @grzesiek . Also see how https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/Makefile#L192 which has a dependency on gitlab-workhorse/.git/pull, which we never create.

@jacobvosmaer-gitlab I just ran into this as well when updating my existing install.

mentioned in merge request !238 (closed)

closed via commit 56253882

Thanks @jacobvosmaer-gitlab, works great now.

Yay!