GDK app does not start after update to recent version that uses Gitaly

Problem

GDK installation ~ 3 month old

Follow update procedure from https://gitlab.com/gitlab-org/gitlab-development-kit/blob/master/doc/update-gdk.md

Get following error when try to run app

./run
...
16:23:49 gitaly.1                | 2017/04/12 16:23:49 Starting Gitaly 
16:23:49 gitaly.1                | 2017/04/12 16:23:49 Must set $GITALY_SOCKET_PATH or $GITALY_LISTEN_ADDR

Tried make gitaly-setup- did not help either.

Solution

Looked into gitaly config it appears to be empty (0 bytes).

→ cat /Users/dzaporozhets/Projects/gitlab-development-kit/gitaly/config.toml

Removing config and run make solved the problem:

rm gitaly/config.toml; make

Thanks @jacobvosmaer-gitlab for help

One part of the problem is our use of the sed s/foo/bar/ source_file > target_file pattern. That creates the target file even if the sed command fails.

The other problem here is that gdk reconfigure was not fixing anything. That might mean we overlook gitaly/config.toml when nuking configs (nuking config is part of reconfigure; it forces gdk to re-create the config files).

mentioned in merge request !287 (merged)

closed via commit 002b633f

mentioned in commit 002b633f