GitLab Development Kit merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests2016-09-29T12:15:35Zhttps://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/197bsd-compatible makefile2016-09-29T12:15:35Zusername-removed-734577guis@acm.orgbsd-compatible makefileThe "shell" function -- $(shell cmd), to execute cmd in the shell -- is a GNU extensions. There are two options: one of them is to use the grave accent, as in this proposed change; the other is to use the shell assignment operator "!=", ...The "shell" function -- $(shell cmd), to execute cmd in the shell -- is a GNU extensions. There are two options: one of them is to use the grave accent, as in this proposed change; the other is to use the shell assignment operator "!=", originally found in BSDs and implemented by GNU make later.https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/198improves mysql installation doc2016-10-10T08:46:06Zusername-removed-117638improves mysql installation docThe information presented in the doc was not correct this MR aims to fix thatThe information presented in the doc was not correct this MR aims to fix thatJacob Vosmaer (GitLab)Jacob Vosmaer (GitLab)https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/199Corrected typo in section title2016-09-30T11:00:08Zusername-removed-753072Corrected typo in section titleLetters in "from" were inadvertently transposed as "form"Letters in "from" were inadvertently transposed as "form"https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/200I think it's critical to note that it may not be obvious for every user that ...2016-10-04T15:37:01Zusername-removed-511262I think it's critical to note that it may not be obvious for every user that eve…I think it's critical to note that it may not be obvious for every user that ever choses to use vagrant with docker, that when the multiple prompts to enter the password upon "vagrant run" i.e when Resyncing folders, appear, they are act...I think it's critical to note that it may not be obvious for every user that ever choses to use vagrant with docker, that when the multiple prompts to enter the password upon "vagrant run" i.e when Resyncing folders, appear, they are actually all for different operations, so some users may think that they are actually key'ing in the wrong password.https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/201Change readme steps from bullet to numbered list2016-10-10T14:28:10Zusername-removed-408677Change readme steps from bullet to numbered listSince the line before the steps mention the number of steps, I think it would be better to change the bullet list to a numbered listSince the line before the steps mention the number of steps, I think it would be better to change the bullet list to a numbered listJacob Vosmaer (GitLab)Jacob Vosmaer (GitLab)https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/202Ignore local gemset configuration2016-10-10T09:12:52Zusername-removed-99119artem@posteo.deIgnore local gemset configurationWhy? For the case you have different gemsets for different development areas (to avoid gem collisions etc)Why? For the case you have different gemsets for different development areas (to avoid gem collisions etc)https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/203Link to rbenv/chruby2016-10-10T09:04:03Zusername-removed-278516Link to rbenv/chrubySimilar to 4a5099c563e39ac76d8df155d6514fefb22c00ddSimilar to 4a5099c563e39ac76d8df155d6514fefb22c00ddhttps://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/204Adding OSX macports installation instructions2016-10-12T12:44:12Zusername-removed-720965Adding OSX macports installation instructionshttps://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/205Auto-correct port assignment2016-11-04T16:04:59Zusername-removed-262636Auto-correct port assignmentAllow Vagrant to re-assign ports if default port (3000) is already
taken.Allow Vagrant to re-assign ports if default port (3000) is already
taken.https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/206Adding OpenSUSE instructions, and fix leftover garbage text at bottom of prep...2016-11-18T12:59:40Zusername-removed-510609Adding OpenSUSE instructions, and fix leftover garbage text at bottom of prepare.mdAdd open-suse instructions, noting that Tumbleweed is not yet known to work. Will send a second MR when I get tumbleweed to work,
and when Leap 42.2 is out, if any further changes arise.
Bottom of the file should have probably just l...Add open-suse instructions, noting that Tumbleweed is not yet known to work. Will send a second MR when I get tumbleweed to work,
and when Leap 42.2 is out, if any further changes arise.
Bottom of the file should have probably just linked to the real installation instructions. I tried to fix that too.
Visual review: https://gitlab.com/warren.postma/gitlab-development-kit/blob/readme-add-opensuse/doc/prepare.md
OpenSuSE Tumbleweed 20161109 is blocked on problems with libicu support from the charlock_holmes gem at this time.
Grzegorz BizonGrzegorz Bizonhttps://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/207Add `npm install` to `gdk update`2016-11-01T17:26:08ZLuke "Jared" BennettAdd `npm install` to `gdk update`Update the `gitlab-update` rule with an `npm install` system command.Update the `gitlab-update` rule with an `npm install` system command.Jacob Vosmaer (GitLab)Jacob Vosmaer (GitLab)https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/208Use $host for slapd2016-11-01T15:25:53Zusername-removed-444214Use $host for slapdJacob Vosmaer (GitLab)Jacob Vosmaer (GitLab)https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/209Refuse to run if the GDK root was moved2016-10-31T12:55:40ZJacob Vosmaer (GitLab)Refuse to run if the GDK root was movedThis is a cause of problems for users. Although we already made fixing
it easy (gdk reconfigure) it was still hard for users to detect /
understand what was wrong.This is a cause of problems for users. Although we already made fixing
it easy (gdk reconfigure) it was still hard for users to detect /
understand what was wrong.https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/210Improve gem update explanation2016-10-31T16:57:21ZJacob Vosmaer (GitLab)Improve gem update explanationhttps://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/211Add psql, redis-cli subcommands2016-11-02T12:09:53ZJacob Vosmaer (GitLab)Add psql, redis-cli subcommandsThis makes it easier to connect to the Postgres, Redis databases spawned by `gdk run db`.This makes it easier to connect to the Postgres, Redis databases spawned by `gdk run db`.Jacob Vosmaer (GitLab)Jacob Vosmaer (GitLab)https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/212Document how to recompile gitlab-workhorse in GDK2016-11-02T19:11:10ZJacob Vosmaer (GitLab)Document how to recompile gitlab-workhorse in GDKWhen you run `make` in gitlab-workhorse in GDK you compile new
binaries but those do not get picked up by `gdk run`. You have to use
`gdk install` instead.When you run `make` in gitlab-workhorse in GDK you compile new
binaries but those do not get picked up by `gdk run`. You have to use
`gdk install` instead.Grzegorz BizonGrzegorz Bizonhttps://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/213Improve "GDK_ROOT not found" message2016-11-23T16:01:43ZJacob Vosmaer (GitLab)Improve "GDK_ROOT not found" messageCloses https://gitlab.com/gitlab-org/gitlab-development-kit/issues/168Closes https://gitlab.com/gitlab-org/gitlab-development-kit/issues/168https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/214Ensure 'cd gitlab' is done in current directory2016-11-10T14:57:16Zusername-removed-493213philip@eswat.caEnsure 'cd gitlab' is done in current directoryFor some reason tmux cannot find the gitlab directory without explicitly prepending the current directory.
Was getting `support/set-gitlab-upstream: line 5: cd: gitlab: No such file or directory` in return without being explicit about...For some reason tmux cannot find the gitlab directory without explicitly prepending the current directory.
Was getting `support/set-gitlab-upstream: line 5: cd: gitlab: No such file or directory` in return without being explicit about the cwd. This change got it working in tmux — while still working outside of it in bash — for me but if there’s a saner alternative I’m all ears.https://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/215Ignore builds/ directory2016-11-23T15:58:03ZAchilleas PipinellisIgnore builds/ directoryIt's created when Runner with shell executor is usedIt's created when Runner with shell executor is usedhttps://staging.gitlab.com/gitlab-org/gitlab-development-kit/-/merge_requests/217Automated GDK tests2016-12-28T18:49:28Zusername-removed-557349Automated GDK testsCloses #167Closes #167Grzegorz BizonGrzegorz Bizon