Skip to content
Snippets Groups Projects

Updated prepare.md with new phantomjs version (2.1.1)

Merged Updated prepare.md with new phantomjs version (2.1.1)
phantomjs-2-1-1-prepare-docs-update into master
2 unresolved threads
Merged Luke "Jared" Bennett requested to merge phantomjs-2-1-1-prepare-docs-update into master
2 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
doc/prepare.md
46 46 # This PPA contains an up-to-date version of Go
47 47 sudo apt-add-repository -y ppa:ubuntu-lxc/lxd-stable
48 48 sudo apt-get update
49 sudo apt-get install git postgresql postgresql-contrib libpq-dev phantomjs redis-server libicu-dev cmake g++ nodejs libkrb5-dev golang ed pkg-config
49 sudo apt-get install git postgresql postgresql-contrib libpq-dev redis-server libicu-dev cmake g++ nodejs libkrb5-dev golang ed pkg-config
50 npm install phantomjs-prebuilt -g
  • username-removed-386624
    username-removed-386624 @connorshea started a thread on an old version of the diff
    • doc/prepare.md
    33 33 brew tap homebrew/versions
    34 34 brew install git redis postgresql libiconv icu4c pkg-config cmake nodejs go openssl node npm
    35 35 bundle config build.eventmachine --with-cppflags=-I/usr/local/opt/openssl/include
    36 npm install phantomjs@1.9.8 -g
    36 npm install phantomjs-prebuilt -g
  • Luke "Jared" Bennett Added 1 commit:

    Added 1 commit:

    • 1f96588e - Lock phantomjs-prebuilt @ v2.1.12 which will lock the phantomjs binary to 2.1.1.
  • Luke "Jared" Bennett
    Luke "Jared" Bennett @lbennett ·
    Author Developer

    Is it right that we install this globally? We can install locally if we always run phantomjs with node_modules/.bin/phantomjs instead. Then it could be in the make script.

  • username-removed-386624
    username-removed-386624 @connorshea ·
    Developer

    @lbennett but then I'd have two installations of phantomjs if I had a GDK for CE and EE.

  • Luke "Jared" Bennett
    Luke "Jared" Bennett @lbennett ·
    Author Developer

    @connorshea You also have two installations of GitLab :wink:

  • username-removed-386624
    username-removed-386624 @connorshea ·
    Developer

    @lbennett that's unavoidable :)

  • Jacob Vosmaer (GitLab)
    Jacob Vosmaer (GitLab) @jacobvosmaer-gitlab ·
    Contributor

    If there is a way to install phantomjs more 'local' that would be nice. But we tend to just target the cutting edge of GitLab in GDK.

  • Jacob Vosmaer (GitLab) Status changed to merged

    Status changed to merged

  • Jacob Vosmaer (GitLab) mentioned in commit 7089e594

    mentioned in commit 7089e594

    • Please register or sign in to reply