Skip to content
Snippets Groups Projects

Add specific CONTRIBUTING.md file

Merged Ernst van Nierop requested to merge evn-add-contr into master

Per https://gitlab.com/gitlab-org/gitlab-development-kit/merge_requests/183#note_13922336 , the plan is to have each project have its own CONTRIBUTING.md, but then from there link to the CLA's in the gitlab-ce repo.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • \cc @jacobvosmaer-gitlab here in a comment instead of in the body of the MR, because the latter would apparently lead to spam of some sort? (how/why?)

    Feel free to take this one too :-) I assigned it to Sid since he asked me for this a long while ago.

  • Jacob Vosmaer (GitLab) Status changed to merged

    Status changed to merged

  • @ernstvn re mention spam: the text in the MR description by default ends up in the commit message of the merge commit. When this merge commit is pushed somewhere, the text of that message is treated similarly to a comment on an issue such as this.

    The problem is that if somebody I don't know has a fork of GitLab (or GDK in this case) and pushes that commit to their fork, then GitLab treats it as if I got mentioned again and sends me an email notification. Which was not the intention of the person updating their fork.

    In other news, thanks for the CONTRIBUTING file!

  • @jacobvosmaer-gitlab thanks for the explanation. Sounds like something worth filing an issue for? Otherwise, it sounds like there should not usually be \cc 's in the body of the MR description...

Please register or sign in to reply
Loading