bsd-compatible makefile
The "shell" function -- $(shell cmd), to execute cmd in the shell -- is a GNU extensions. There are two options: one of them is to use the grave accent, as in this proposed change; the other is to use the shell assignment operator "!=", originally found in BSDs and implemented by GNU make later.
Merge request reports
Activity
I think I would prefer auto-detecting gmake in lib/gdk.rb. I don't think we should take on the burden of having to test the Makefile for BSD Make compatibility all the time.
We should also think about Makefiles in subdirectories that we use. The top-level Makefile should use a $MAKE variable to invoke the correct command.
- auto-detect gmake/make in lib/gdk.rb
- in lib/gdk.rb, instead of invoking
make install
etc., invoke#{make_command} install MAKE=#{make_command}
Added 7 commits:
- eeba3abb...6084530f - 5 commits from branch
gitlab-org:master
- a9601fe0 - bsd-compatible makefile
- 10315de0 - change lib/gdk.rb to use gmake on BSD systems
- eeba3abb...6084530f - 5 commits from branch
- Resolved by Jacob Vosmaer (GitLab)
- Resolved by username-removed-734577
- Resolved by Jacob Vosmaer (GitLab)
- Resolved by username-removed-734577
Added 6 commits:
Toggle commit listAdded 1 commit:
- 316c6fd4 - fix style issue in make variable
@jacobvosmaer-gitlab please let me know when I should go ahead and squash those commits up
Mentioned in commit 980172b5