Skip to content
Snippets Groups Projects

bsd-compatible makefile

Merged username-removed-734577 requested to merge (removed):makefile-freebsd into master
All threads resolved!

The "shell" function -- $(shell cmd), to execute cmd in the shell -- is a GNU extensions. There are two options: one of them is to use the grave accent, as in this proposed change; the other is to use the shell assignment operator "!=", originally found in BSDs and implemented by GNU make later.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Added 1 commit:

    • 5f70f219 - use MAKE builtin variable in Makefile and leverage truthy value in gdk.rb
  • Added 6 commits:

    • 5f70f219...a6ecfa59 - 2 commits from branch gitlab-org:master
    • 09a74aff - bsd-compatible makefile
    • 839be002 - change lib/gdk.rb to use gmake on BSD systems
    • 6614e517 - revert original changes to the Makefile
    • 8af8d3fe - use MAKE builtin variable in Makefile and leverage truthy value in gdk.rb
  • Added 1 commit:

    • 316c6fd4 - fix style issue in make variable
  • username-removed-734577 Resolved all discussions

    Resolved all discussions

  • @jacobvosmaer-gitlab please let me know when I should go ahead and squash those commits up

  • @gmesalazar I am OK with the extra commits :) thanks for the MR and thanks for working with me towards this solution!

  • Jacob Vosmaer (GitLab) Status changed to merged

    Status changed to merged

  • Mentioned in commit 980172b5

  • username-removed-734577 Changed title: RFC: bsd-compatible makefilebsd-compatible makefile

    Changed title: RFC: bsd-compatible makefilebsd-compatible makefile

  • Please register or sign in to reply
    Loading