Add `npm install` to `gdk update`
Update the gitlab-update
rule with an npm install
system command.
Merge request reports
Activity
Reassigned to @jacobvosmaer-gitlab
@jacobvosmaer-gitlab frontend has started to move dependencies over to
package.json
, hence the desire to usenpm install
to make sure dependencies are updated@lbennett What is going to get installed here?
@jschatz1 Everything in
package.json
.For now thats...
"eslint": "^3.1.1", "eslint-config-airbnb": "^12.0.0", "eslint-plugin-import": "^2.0.1", "eslint-plugin-jsx-a11y": "^2.2.3", "eslint-plugin-react": "^6.4.1"
But in the future it will be Webpack and all of our frontend libs.
Edited by Luke "Jared" Bennett- Resolved by Luke "Jared" Bennett
Where will npm install this stuff?
npm packages are installed in the
node_modules
directory, which by default is created at the same root as thepackage.json
file. Which is in thegitlab
repository. So,${gitlab_development_root}/gitlab/node_modules/
.@lbennett OK. Is node_modules in the .gitignore of gitlab-ce already?
/node_modules/
is ingitlab/.gitignore
:)Reassigned to @lbennett
Added 1 commit:
-
915f13aa - Update the
gitlab-update
rule with annpm install
system command.
-
915f13aa - Update the
Reassigned to @jacobvosmaer-gitlab
Mentioned in commit 5db0a1f2
Thanks @lbennett !