Skip to content
Snippets Groups Projects

Document how to recompile gitlab-workhorse in GDK

Merged Document how to recompile gitlab-workhorse in GDK
workhorse-recompile into master
1 unresolved thread
Merged Jacob Vosmaer (GitLab) requested to merge workhorse-recompile into master
1 unresolved thread

When you run make in gitlab-workhorse in GDK you compile new binaries but those do not get picked up by gdk run. You have to use gdk install instead.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
gitlab-workhorse/README.md
1 1 # GitLab-Workhorse in GitLab Development Kit
2 2
3 In GDK, gitlab-workhorse is installed inside its own GOPATH rooted here.
3 Use `gdk install` if you want to recompile gitlab-workhorse for `gdk run`.
  • Jacob Vosmaer (GitLab)
    Jacob Vosmaer (GitLab) @jacobvosmaer-gitlab ·
    Author Contributor

    This is needed because I wanted to keep the Makefile in gitlab-workhorse backwards compatible (and easy to use for people installing GitLab from source) while also using a GOPATH in gitlab-workhorse.

    cc @nick.thomas

  • Jacob Vosmaer (GitLab) Reassigned to @grzesiek

    Reassigned to @grzesiek

  • Nick Thomas
    Nick Thomas @nick.thomas ·
    Maintainer

    Seems reasonable to me, I wouldn't expect make and gdk ... to operate on the same objects at all times.

  • Grzegorz Bizon
    Grzegorz Bizon @grzesiek ·
    Maintainer

    @jacobvosmaer-gitlab Looks good to me, thanks!

  • Grzegorz Bizon Mentioned in commit 4fff9e0b

    Mentioned in commit 4fff9e0b

  • Grzegorz Bizon Status changed to merged

    Status changed to merged

    • Please register or sign in to reply