Start webpack-dev-server directly

Starting with npm run creates an intermediary npm process under Foreman, which prevents Foreman from shutting down webpack-dev-server.

added 1 commit

• d2f893ca - Start webpack-dev-server directly

Compare with previous version

restored source branch webpack-without-npm

added 1 commit

• 1ad32e2b - 1 commit from branch master

Compare with previous version

@jacobvosmaer-gitlab Apparently it didn't work :(

assigned to @jacobvosmaer-gitlab

Yep it still fails with 'port taken'.

It's strange. Locally I see this in the output of gdk run db:

10:28:13 redis.1                 | started with pid 48283
10:28:13 postgresql.1            | started with pid 48284
10:28:13 webpack.1               | started with pid 48285
10:28:13 redis.1                 | 48283:M 10 Feb 10:28:13.639 * Increased maximum number of open files to 10032 (it was originally set to 256).
<snip redis>
10:28:13 postgresql.1            | LOG:  database system was shut down at 2017-02-09 16:30:38 CET
10:28:13 postgresql.1            | LOG:  MultiXact member wraparound protections are now enabled
10:28:13 postgresql.1            | LOG:  autovacuum launcher started
10:28:13 postgresql.1            | LOG:  database system is ready to accept connections
10:28:14 webpack.1               |  http://localhost:8080/webpack-dev-server/
10:28:14 webpack.1               | webpack result is served from /
10:28:14 webpack.1               | content is served from /foobar/gitlab-development-kit/gitlab

In the failed test run:

15:51:57 postgresql.1            | LOG:  autovacuum launcher started
15:51:58 webpack.1               | 
15:51:58 webpack.1               | > @ dev-server /home/gdk/gitlab-development-kit/gitlab
15:51:58 webpack.1               | > webpack-dev-server --config config/webpack.config.js
15:51:58 webpack.1               | 
15:51:58 webpack.1               |  http://localhost:3808/webpack-dev-server/
15:51:58 webpack.1               | webpack result is served from //localhost:3808/assets/webpack/
15:51:58 webpack.1               | content is served from /home/gdk/gitlab-development-kit/gitlab
15:52:23 webpack.1               | Hash: 49a6b1ce1f9ccde3910a
15:52:23 webpack.1               | Version: webpack 1.14.0

It looks like that run still used npm. Why?

added 1 commit

• a75624ea - CI debugging: cat Procfile

Compare with previous version

A workaround with killall node was merged in https://gitlab.com/gitlab-org/gitlab-development-kit/merge_requests/253, so we can close this MR.

closed

It looks like this should be solved by recent changes to webpack-dev-server:

see: https://github.com/webpack/webpack-dev-server/pull/787

mentioned in merge request !289 (merged)