Skip to content
Snippets Groups Projects

Use printf to print binary characters

Merged Jacob Vosmaer (GitLab) requested to merge 204-echo-e into master

Closes #204 (closed)

The reason we have echo -e is to be able to use things like \033 for colors. But echo -e is not portable. I am hoping printf is.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Grzegorz Bizon mentioned in commit 0665ef27

    mentioned in commit 0665ef27

  • @jacobvosmaer-gitlab LGTM! :thumbsup:

    By the way, we seem to have unrelated test failure:

    ERROR:  relation "index_routes_on_path_text_pattern_ops" already exists
    17:45:18 postgresql.1            | STATEMENT:  CREATE INDEX CONCURRENTLY index_routes_on_path_text_pattern_ops ON routes (path varchar_pattern_ops);
    rake aborted!
    ActiveRecord::StatementInvalid: PG::DuplicateTable: ERROR:  relation "index_routes_on_path_text_pattern_ops" already exists
    : CREATE INDEX CONCURRENTLY index_routes_on_path_text_pattern_ops ON routes (path varchar_pattern_ops);
    /home/gdk/gitlab-development-kit/gitlab/db/migrate/20170317203554_index_routes_path_for_like.rb:18:in `up'

    Is 20170317203554_index_routes_path_for_like.rb broken? :thinking:

  • By the way, we seem to have unrelated test failure

    Solved on Slack. Thanks @smcgivern :purple_heart:

Please register or sign in to reply
Loading