nginx.conf depends on nginx.conf.example
Closed
requested to merge nick.thomas/gitlab-development-kit:nginx-conf-depends-on-nginx-conf-example into master
1 unresolved thread
Updating nginx.conf.example
(in source control) should cause nginx.conf
to be regenerated.
Merge request reports
Activity
282 282 283 283 nginx-setup: nginx/conf/nginx.conf nginx/logs nginx/tmp 284 284 285 nginx/conf/nginx.conf: 285 nginx/conf/nginx.conf: nginx/conf/nginx.conf.example @nick.thomas this is actually something we avoid on purpose.
The thing is, like this, people's config changes get overwritten by
make
when they update GDK. Instead of these direct dependencies we list config files in theclean-config
task to that they get regenerated duringgdk reconfigure
.@grzesiek I am not crazy, this is how it works isn't it?
mentioned in merge request !288 (merged)
Closing in favor of https://gitlab.com/gitlab-org/gitlab-development-kit/merge_requests/288
Please register or sign in to reply