An error occurred while fetching the assigned milestone of the selected merge_request.
nginx.conf depends on nginx.conf.example
Closed
requested to merge nick.thomas/gitlab-development-kit:nginx-conf-depends-on-nginx-conf-example into master
1 unresolved thread
Compare changes
+ 1
− 1
@nick.thomas this is actually something we avoid on purpose.
The thing is, like this, people's config changes get overwritten by
make
when they update GDK. Instead of these direct dependencies we list config files in theclean-config
task to that they get regenerated duringgdk reconfigure
.@grzesiek I am not crazy, this is how it works isn't it?
Heh. It caught me out while debugging another issue. If it's intentional, no problem!
Changes to configs being overwritten when running
gdk reconfigure
is not ideal situation, but I suppose this is best what we can do currently, right?