Make gitlab-git-http-server work with nginx

Thanks @stanhu , I must have been editing nginx.conf instead of nginx.conf.example on my laptop.

Does it work in this order, before gitlab proper?

Added 1 commit:

• 7d0707f6 - Add rule for gitlab-git-http-server

I think either order is fine, but to be consistent with omnibus I just put it after the / location.

Added 1 commit:

• 0483da3c - Add nginx PID and proxy_temp settings

I also added other changes so that nginx would run within the GDK environment. Couldn't figure out how to make a tmp/nginx directory so I just pointed it to tmp. Looks like nginx attempts to create the temp directory if it doesn't exist.

Added 1 commit:

• c46fc123 - Use tmp/nginx since nginx appears to create this dir

Title changed from Add rule for gitlab-git-http-server to Make gitlab-git-http-server work with nginx

@stanhu where do you see the pid file appear?

By default, it looks like my nginx attempts to write into /usr/local/var/run/nginx.pid.

Yes I see it too now. I would prefer a solution like this:

• nginx/tmp in .gitignore
• mkdir -p nginx/tmp in the Makefile
• pidfile tmp/nginx.pid in nginx.conf

NGINX should put its proxy_temp stuff in GDK/nginx. But that is not happening for you @stanhu ?

should be fixed by https://gitlab.com/gitlab-org/gitlab-development-kit/compare/db421c9d018ad269740b9ade91106b3c266a968b...efe80bfbddae6db8de61f619647712f858ab4193

Status changed to closed

Thanks, Jacob!