Skip to content
Snippets Groups Projects

Lazily load LiteBlob#data

Merged Lazily load LiteBlob#data
nick.thomas/gitlab-elasticsearch-git:lazily-load-blob-content into master
2 unresolved threads
Merged Nick Thomas requested to merge nick.thomas/gitlab-elasticsearch-git:lazily-load-blob-content into master
2 unresolved threads

Some operations, notably Repository#delete_blob, don't need access to the blob content. Loading it from disc in these cases is unnecessary.

This commit lazily loads the content on first access and memoizes it. If it is never accessed, it will never be loaded.

This should reduce disc access significantly for commits that delete lots of files.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nick Thomas
    Nick Thomas @nick.thomas started a thread on the diff
  • Valery Sizov
    Valery Sizov @vsizov ·
    Contributor

    @nick.thomas Specs are red

  • Valery Sizov assigned to @nick.thomas

    assigned to @nick.thomas

  • Nick Thomas added 1 commit

    added 1 commit

    Compare with previous version

  • Nick Thomas
    Nick Thomas @nick.thomas ·
    Author Maintainer

    Whoops! Fixed ^^

  • Nick Thomas assigned to @vsizov

    assigned to @vsizov

  • Valery Sizov
    Valery Sizov @vsizov ·
    Contributor

    Thanks, LGTM

  • Valery Sizov mentioned in commit 24982017

    mentioned in commit 24982017

  • Valery Sizov merged

    merged

    • Please register or sign in to reply