Skip to content
Snippets Groups Projects

Correctly handle a FROM_SHA value of 000000...

Merged Correctly handle a FROM_SHA value of 000000...
5-fix-from-sha-zeroes into master
Merged Nick Thomas requested to merge 5-fix-from-sha-zeroes into master
Viewing commit 9e4d0cb6
Show latest version
3 files
+ 8
− 7
Compare changes
  • Side-by-side
  • Inline
Files
3
git/go-git.go
+ 2
− 5
@@ -32,12 +32,9 @@ func NewGoGitRepository(projectPath string, fromSHA string, toSHA string) (*goGi
@@ -32,12 +32,9 @@ func NewGoGitRepository(projectPath string, fromSHA string, toSHA string) (*goGi
return nil, err
return nil, err
}
}
out.Repository = repo
out.Repository = repo
 
out.FromHash = plumbing.NewHash(fromSHA)
if fromSHA == "" {
if !out.FromHash.IsZero() {
out.FromHash = plumbing.ZeroHash
} else {
out.FromHash = plumbing.NewHash(fromSHA)
commit, err := repo.CommitObject(out.FromHash)
commit, err := repo.CommitObject(out.FromHash)
if err != nil {
if err != nil {
return nil, fmt.Errorf("Bad from SHA (%s): %s", out.FromHash, err)
return nil, fmt.Errorf("Bad from SHA (%s): %s", out.FromHash, err)