Skip to content
Snippets Groups Projects
Nick Thomas's avatar
closed merge request !2 "Initial implementation using libgit2" at GitLab.org / gitlab-elasticsearch-indexer
Robert Speicher's avatar
Nick Thomas's avatar
Nick Thomas's avatar
Nick Thomas's avatar
deleted branch add-contributing at GitLab.org / gitlab-elasticsearch-indexer
Nick Thomas's avatar
accepted merge request !8 "Add CONTRIBUTING.md" at GitLab.org / gitlab-elasticsearch-indexer
Nick Thomas's avatar
Nick Thomas's avatar
opened merge request !8 "Add CONTRIBUTING.md" at GitLab.org / gitlab-elasticsearch-indexer
Nick Thomas's avatar
pushed new branch add-contributing at GitLab.org / gitlab-elasticsearch-indexer
username-removed-487110's avatar
commented on merge request !7 "Fix a runtime panic" at GitLab.org / gitlab-elasticsearch-indexer

But as you say, making it injectable is way to much work IMO

username-removed-487110's avatar
commented on merge request !7 "Fix a runtime panic" at GitLab.org / gitlab-elasticsearch-indexer

Fix looks fine. Something that usually breaks encodings is mixing English ASCII-8 with say Chinese UTF-16 in the same string (yes, been there, done...

Nick Thomas's avatar
commented on merge request !7 "Fix a runtime panic" at GitLab.org / gitlab-elasticsearch-indexer

@bkc can I get you to review this for me?...

Nick Thomas's avatar
opened merge request !7 "Fix a runtime panic" at GitLab.org / gitlab-elasticsearch-indexer
Nick Thomas's avatar
pushed new branch 8-fix-runtime-panic at GitLab.org / gitlab-elasticsearch-indexer
Nick Thomas's avatar
commented on issue #7 "Content-Type is not set on elasticsearch client requests" at GitLab.org / gitlab-elasticsearch-indexer

I've opened an issue with upstream: https://github.com/olivere/elastic/issues/578

Nick Thomas's avatar
commented on merge request !6 "adding chained aws credentials support" at GitLab.org / gitlab-elasticsearch-indexer

OK, this is merged. I'll cut a 0.2.0 and get it into %9.4...

Nick Thomas's avatar
Nick Thomas's avatar