Skip to content
Snippets Groups Projects
Select Git revision
  • ag-test
  • rs-test
  • master default protected
  • test-me-pa
  • mksionek-master-patch-52381
  • new-branch-10
  • test-conflicts
  • test-suggestions
  • alejandro-test
  • patch-25
  • winh-test-image-doscussion
  • stg-lfs-image-test-2
  • stg-lfs-image-test
  • test42016
  • issue_42016
  • issue-32709
  • add-codeowners
  • ClemMakesApps-master-patch-62759
  • bvl-staging-test
  • bvl-merge-base-api
  • v9.2.0-rc6 protected
  • v9.2.0-rc5 protected
  • v9.2.0-rc4 protected
  • v9.2.0-rc3 protected
  • v9.1.4 protected
  • v9.2.0-rc2 protected
  • v9.2.0-rc1 protected
  • v9.1.3 protected
  • v8.17.6 protected
  • v9.0.7 protected
  • v9.1.2 protected
  • v9.1.1 protected
  • v9.2.0.pre protected
  • v9.1.0 protected
  • v9.1.0-rc7 protected
  • v9.1.0-rc6 protected
  • v9.0.6 protected
  • v9.1.0-rc5 protected
  • v9.1.0-rc4 protected
  • v9.1.0-rc3 protected
40 results

30973-network-graph-sorted-by-date-and-topo.yml

  • Timothy Andrew's avatar
    b44eaf8e
    Sort the network graph both by commit date and topographically. · b44eaf8e
    Timothy Andrew authored
    - Previously, we sorted commits by date, which seemed to work okay.
    
    - The one edge case where this failed was when multiple commits have the same
      commit date (for example: when a range of commits are cherry picked with a
      single command, they all have the same commit date [and different author
      dates]).
    
    - Commits with the same commit date would be sorted arbitrarily, and usually
      break the network graph.
    
    - This commit solves the problem by both sorting by date, and by sorting
      topographically (parents aren't displayed until all their children are
      displayed)
    
    - Include review comments from @adamniedzielski
    
    A more detailed explanation is present here:
    https://gitlab.com/gitlab-org/gitlab-ce/issues/30973#note_28706230
    b44eaf8e
    History
    Sort the network graph both by commit date and topographically.
    Timothy Andrew authored
    - Previously, we sorted commits by date, which seemed to work okay.
    
    - The one edge case where this failed was when multiple commits have the same
      commit date (for example: when a range of commits are cherry picked with a
      single command, they all have the same commit date [and different author
      dates]).
    
    - Commits with the same commit date would be sorted arbitrarily, and usually
      break the network graph.
    
    - This commit solves the problem by both sorting by date, and by sorting
      topographically (parents aren't displayed until all their children are
      displayed)
    
    - Include review comments from @adamniedzielski
    
    A more detailed explanation is present here:
    https://gitlab.com/gitlab-org/gitlab-ce/issues/30973#note_28706230
Code owners
Assign users and groups as approvers for specific file changes. Learn more.