Skip to content
Snippets Groups Projects
Select Git revision
  • ag-test
  • rs-test
  • master default protected
  • test-me-pa
  • mksionek-master-patch-52381
  • new-branch-10
  • test-conflicts
  • test-suggestions
  • alejandro-test
  • patch-25
  • winh-test-image-doscussion
  • stg-lfs-image-test-2
  • stg-lfs-image-test
  • test42016
  • issue_42016
  • issue-32709
  • add-codeowners
  • ClemMakesApps-master-patch-62759
  • bvl-staging-test
  • bvl-merge-base-api
  • v9.2.0-rc6 protected
  • v9.2.0-rc5 protected
  • v9.2.0-rc4 protected
  • v9.2.0-rc3 protected
  • v9.1.4 protected
  • v9.2.0-rc2 protected
  • v9.2.0-rc1 protected
  • v9.1.3 protected
  • v8.17.6 protected
  • v9.0.7 protected
  • v9.1.2 protected
  • v9.1.1 protected
  • v9.2.0.pre protected
  • v9.1.0 protected
  • v9.1.0-rc7 protected
  • v9.1.0-rc6 protected
  • v9.0.6 protected
  • v9.1.0-rc5 protected
  • v9.1.0-rc4 protected
  • v9.1.0-rc3 protected
40 results

remove-sidekiq-backup-ar-threads.yml

  • Yorick Peterse's avatar
    f116f87c
    Don't use backup AR connections for Sidekiq · f116f87c
    Yorick Peterse authored
    Adding two extra connections does nothing other than increasing the
    number of idle database connections. Given Sidekiq uses N threads it can
    never use more than N AR connections at a time, thus we don't need more.
    
    The initializer mentioned the Sidekiq upgrade guide stating this was
    required.  This is false, the Sidekiq upgrade guide states this is
    necessary for Redis and not ActiveRecord.
    
    On GitLab.com this resulted in a reduction of about 80-100 PostgreSQL
    connections.
    
    Fixes #27713
    Verified
    f116f87c
    History
    Don't use backup AR connections for Sidekiq
    Yorick Peterse authored
    Adding two extra connections does nothing other than increasing the
    number of idle database connections. Given Sidekiq uses N threads it can
    never use more than N AR connections at a time, thus we don't need more.
    
    The initializer mentioned the Sidekiq upgrade guide stating this was
    required.  This is false, the Sidekiq upgrade guide states this is
    necessary for Redis and not ActiveRecord.
    
    On GitLab.com this resulted in a reduction of about 80-100 PostgreSQL
    connections.
    
    Fixes #27713
Code owners
Assign users and groups as approvers for specific file changes. Learn more.