diff --git a/lib/gitlab/ci/status/build/failed_allowed.rb b/lib/gitlab/ci/status/build/failed_allowed.rb index 8693bd5849fe9edee1dcf7caf537587bf4837994..807afe24bd5765f695cd3cf88d8c6b618a4930c8 100644 --- a/lib/gitlab/ci/status/build/failed_allowed.rb +++ b/lib/gitlab/ci/status/build/failed_allowed.rb @@ -13,10 +13,6 @@ module Gitlab 'icon_status_warning' end - def favicon - 'favicon_status_warning' - end - def group 'failed_with_warnings' end diff --git a/lib/gitlab/ci/status/success_warning.rb b/lib/gitlab/ci/status/success_warning.rb index 9b735ed235ae45ed5deb3034d4c14350362f44bd..d4cdab6957a00c835c7996b02aac7f62bb14e88a 100644 --- a/lib/gitlab/ci/status/success_warning.rb +++ b/lib/gitlab/ci/status/success_warning.rb @@ -20,10 +20,6 @@ module Gitlab 'icon_status_warning' end - def favicon - 'favicon_status_warning' - end - def group 'success_with_warnings' end diff --git a/spec/lib/gitlab/ci/status/build/factory_spec.rb b/spec/lib/gitlab/ci/status/build/factory_spec.rb index f6bc3eac9e3014276b19420a6057beef377b2a1f..e648a3ac3a27c49752cdee98a7086707b710023f 100644 --- a/spec/lib/gitlab/ci/status/build/factory_spec.rb +++ b/spec/lib/gitlab/ci/status/build/factory_spec.rb @@ -81,7 +81,7 @@ describe Gitlab::Ci::Status::Build::Factory do it 'fabricates status with correct details' do expect(status.text).to eq 'failed' expect(status.icon).to eq 'icon_status_warning' - expect(status.favicon).to eq 'favicon_status_warning' + expect(status.favicon).to eq 'favicon_status_failed' expect(status.label).to eq 'failed (allowed to fail)' expect(status).to have_details expect(status).to have_action diff --git a/spec/lib/gitlab/ci/status/build/failed_allowed_spec.rb b/spec/lib/gitlab/ci/status/build/failed_allowed_spec.rb index b39ccbb1f60a4fd2a42b56f9dc32d27b944615c4..20f714597385bf5170dbd754371710500502c5a5 100644 --- a/spec/lib/gitlab/ci/status/build/failed_allowed_spec.rb +++ b/spec/lib/gitlab/ci/status/build/failed_allowed_spec.rb @@ -22,12 +22,6 @@ describe Gitlab::Ci::Status::Build::FailedAllowed do end end - describe '#favicon' do - it 'returns a warning favicon' do - expect(subject.favicon).to eq 'favicon_status_warning' - end - end - describe '#label' do it 'returns information about failed but allowed to fail status' do expect(subject.label).to eq 'failed (allowed to fail)' diff --git a/spec/lib/gitlab/ci/status/success_warning_spec.rb b/spec/lib/gitlab/ci/status/success_warning_spec.rb index 19d0da499f939f0d1abbbfe592ea637338171f03..7e2269397c667691e9450cbd0bd1b12355d7627f 100644 --- a/spec/lib/gitlab/ci/status/success_warning_spec.rb +++ b/spec/lib/gitlab/ci/status/success_warning_spec.rb @@ -17,10 +17,6 @@ describe Gitlab::Ci::Status::SuccessWarning do it { expect(subject.icon).to eq 'icon_status_warning' } end - describe '#favicon' do - it { expect(subject.favicon).to eq 'favicon_status_warning' } - end - describe '#group' do it { expect(subject.group).to eq 'success_with_warnings' } end