From 5608e1a159318892abc78ccbd8db1ac7090c6a80 Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin <godfat@godfat.org> Date: Wed, 15 Jun 2016 16:23:41 +0800 Subject: [PATCH] Raise first like an input check --- lib/gitlab/email/receiver.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/gitlab/email/receiver.rb b/lib/gitlab/email/receiver.rb index 77ed6b9f7d9..9213cfb51e8 100644 --- a/lib/gitlab/email/receiver.rb +++ b/lib/gitlab/email/receiver.rb @@ -30,11 +30,9 @@ module Gitlab mail_key = extract_mail_key(mail) handler = Handler.for(mail, mail_key) - if handler - handler.execute - else - raise UnknownIncomingEmail - end + raise UnknownIncomingEmail unless handler + + handler.execute end def build_mail -- GitLab