diff --git a/app/models/project.rb b/app/models/project.rb index 35ffb0a415d751df55a1ac9d6fdc195cf7df2064..bc15f8c4138c2e52c4a2be4854401b1e3e219a7d 100644 --- a/app/models/project.rb +++ b/app/models/project.rb @@ -431,7 +431,7 @@ class Project < ActiveRecord::Base def builds_for(build_name, ref = 'HEAD') ct = commit(ref) - return [] unless ct + return builds.none unless ct sha = commit(ref).sha diff --git a/spec/models/build_spec.rb b/spec/models/build_spec.rb index c7c247189f5be0a84613cfbaabf73e42434caa4c..b1354faa722112f0b58c6892ac7bc677c6c5ee17 100644 --- a/spec/models/build_spec.rb +++ b/spec/models/build_spec.rb @@ -697,5 +697,11 @@ describe Ci::Build, models: true do expect(build_ids).to eq([build.id]) end + + it 'returns empty relation if the build cannot be found' do + builds = project.builds_for(build.name, 'TAIL').all + + expect(builds).to be_empty + end end end