From 6b07a5b26c115e0844e6e74efe6c6405c5a82812 Mon Sep 17 00:00:00 2001
From: Kamil Trzcinski <ayufan@ayufan.eu>
Date: Tue, 19 Jul 2016 14:53:31 +0200
Subject: [PATCH] Improve code design
---
app/models/ci/build.rb | 1 +
lib/ci/gitlab_ci_yaml_processor.rb | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/models/ci/build.rb b/app/models/ci/build.rb
index 775e2d363ea..e02351ce339 100644
--- a/app/models/ci/build.rb
+++ b/app/models/ci/build.rb
@@ -457,6 +457,7 @@ module Ci
def build_attributes_from_config
return {} unless pipeline.config_processor
+
pipeline.config_processor.build_attributes(name)
end
end
diff --git a/lib/ci/gitlab_ci_yaml_processor.rb b/lib/ci/gitlab_ci_yaml_processor.rb
index d1ce6de5a7d..83afed9f49f 100644
--- a/lib/ci/gitlab_ci_yaml_processor.rb
+++ b/lib/ci/gitlab_ci_yaml_processor.rb
@@ -44,7 +44,7 @@ module Ci
end
def builds_for_ref(ref, tag = false, trigger_request = nil)
- jobs_for_ref(ref, tag, trigger_request).map do |name, job|
+ jobs_for_ref(ref, tag, trigger_request).map do |name, _|
build_attributes(name)
end
end
--
GitLab