From 73b8390768f1e243a16862acdbf4b8be7666acef Mon Sep 17 00:00:00 2001
From: Alfredo Sumaran <alfredo@gitlab.com>
Date: Mon, 21 Nov 2016 12:51:34 -0500
Subject: [PATCH] Remove unnecesary variable

This will be removed until we figure out in what scenario we should display the overview message.
---
 .../projects/cycle_analytics/show.html.haml   | 167 +++++++++---------
 1 file changed, 82 insertions(+), 85 deletions(-)

diff --git a/app/views/projects/cycle_analytics/show.html.haml b/app/views/projects/cycle_analytics/show.html.haml
index da9823e78fe..12180c82eae 100644
--- a/app/views/projects/cycle_analytics/show.html.haml
+++ b/app/views/projects/cycle_analytics/show.html.haml
@@ -1,92 +1,89 @@
 - @no_container = true
 - @cycle_analytics_not_set_up = false
 - page_title "Cycle Analytics"
+- content_for :page_specific_javascripts do
+  = page_specific_javascript_tag("cycle_analytics/cycle_analytics_bundle.js")
 
 = render "projects/pipelines/head"
 
-- if @cycle_analytics_not_set_up
-  = render partial: "overview"
-- else
-  - content_for :page_specific_javascripts do
-    = page_specific_javascript_tag("cycle_analytics/cycle_analytics_bundle.js")
-  #cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } }
-    .bordered-box.landing.content-block{"v-if" => "!isOverviewDialogDismissed"}
-      = icon("times", class: "dismiss-icon", "@click" => "dismissOverviewDialog()")
-      .row
-        .col-sm-3.col-xs-12.svg-container
-          = custom_icon('icon_cycle_analytics_splash')
-        .col-sm-8.col-xs-12.inner-content
-          %h4
-            Introducing Cycle Analytics
-          %p
-            Cycle Analytics gives an overview of how much time it takes to go from idea to production in your project.
+#cycle-analytics{ class: container_class, "v-cloak" => "true", data: { request_path: project_cycle_analytics_path(@project) } }
+  .bordered-box.landing.content-block{"v-if" => "!isOverviewDialogDismissed"}
+    = icon("times", class: "dismiss-icon", "@click" => "dismissOverviewDialog()")
+    .row
+      .col-sm-3.col-xs-12.svg-container
+        = custom_icon('icon_cycle_analytics_splash')
+      .col-sm-8.col-xs-12.inner-content
+        %h4
+          Introducing Cycle Analytics
+        %p
+          Cycle Analytics gives an overview of how much time it takes to go from idea to production in your project.
 
-          = link_to "Read more",  help_page_path('user/project/cycle_analytics'), target: '_blank', class: 'btn'
-    = icon("spinner spin", "v-show" => "isLoading")
-    .wrapper{"v-show" => "!isLoading && !hasError"}
-      .panel.panel-default
-        .panel-heading
-          Pipeline Health
-        .content-block
-          .container-fluid
-            .row
-              .col-sm-3.col-xs-12.column{"v-for" => "item in state.summary"}
-                %h3.header {{item.value}}
-                %p.text {{item.title}}
-              .col-sm-3.col-xs-12.column
-                .dropdown.inline.js-ca-dropdown
-                  %button.dropdown-menu-toggle{"data-toggle" => "dropdown", :type => "button"}
-                    %span.dropdown-label Last 30 days
-                    %i.fa.fa-chevron-down
-                  %ul.dropdown-menu.dropdown-menu-align-right
-                    %li
-                      %a{ "href" => "#", "data-value" => "30" }
-                        Last 30 days
-                    %li
-                      %a{ "href" => "#", "data-value" => "90" }
-                        Last 90 days
-      .panel.panel-default.stage-panel
-        .panel-heading
-          %nav.col-headers
-            %ul
-              %li.stage-header
-                %span.stage-name
-                  Stage
-                %i.has-tooltip.fa.fa-question-circle{ "data-placement" => "top", title: "The phase of the development lifecycle.", "aria-hidden" => "true" }
-              %li.median-header
-                %span.stage-name
-                  Median
-                %i.has-tooltip.fa.fa-question-circle{ "data-placement" => "top", title: "The value lying at the midpoint of a series of observed values. E.g., between 3, 5, 9, the median is 5. Between 3, 5, 7, 8, the median is (5+7)/2 = 6.", "aria-hidden" => "true" }
-              %li.event-header
-                %span.stage-name
-                  {{ currentStage ? currentStage.legend : 'Related Issues' }}
-                %i.has-tooltip.fa.fa-question-circle{ "data-placement" => "top", title: "The collection of events added to the data gathered for that stage.", "aria-hidden" => "true" }
-              %li.total-time-header
-                %span.stage-name
-                  Total Time
-                %i.has-tooltip.fa.fa-question-circle{ "data-placement" => "top", title: "The time taken by each data entry gathered by that stage.", "aria-hidden" => "true" }
-        .stage-panel-body
-          %nav.stage-nav
-            %ul
-              %li.stage-nav-item{ ':class' => '{ active: stage.active }', '@click' => 'selectStage(stage)', "v-for" => "stage in state.stages" }
-                .stage-name
-                  {{ stage.title }}
-                .stage-median
-                  %template{ "v-if" => "stage.isUserAllowed" }
-                    %span{ "v-if" => "stage.value" }
-                      {{ stage.value }}
-                    %span.stage-empty{ "v-else" => true }
-                      No enough data
-                  %template{ "v-else" => true }
-                    %span.not-available
-                      Not available
-          .section.stage-events
-            %template{ "v-if" => "isLoadingStage" }
-              = icon("spinner spin")
-            %template{ "v-if" => "currentStage && !currentStage.isUserAllowed" }
-              = render partial: "no_access"
-            %template{ "v-else" => true }
-              %template{ "v-if" => "isEmptyStage && !isLoadingStage" }
-                = render partial: "empty_stage"
-              %template{ "v-if" => "state.events.length && !isLoadingStage && !isEmptyStage" }
-                %component{ ":is" => "currentStage.component", ":stage" => "currentStage", ":items" => "state.events" }
+        = link_to "Read more",  help_page_path('user/project/cycle_analytics'), target: '_blank', class: 'btn'
+  = icon("spinner spin", "v-show" => "isLoading")
+  .wrapper{"v-show" => "!isLoading && !hasError"}
+    .panel.panel-default
+      .panel-heading
+        Pipeline Health
+      .content-block
+        .container-fluid
+          .row
+            .col-sm-3.col-xs-12.column{"v-for" => "item in state.summary"}
+              %h3.header {{item.value}}
+              %p.text {{item.title}}
+            .col-sm-3.col-xs-12.column
+              .dropdown.inline.js-ca-dropdown
+                %button.dropdown-menu-toggle{"data-toggle" => "dropdown", :type => "button"}
+                  %span.dropdown-label Last 30 days
+                  %i.fa.fa-chevron-down
+                %ul.dropdown-menu.dropdown-menu-align-right
+                  %li
+                    %a{ "href" => "#", "data-value" => "30" }
+                      Last 30 days
+                  %li
+                    %a{ "href" => "#", "data-value" => "90" }
+                      Last 90 days
+    .panel.panel-default.stage-panel
+      .panel-heading
+        %nav.col-headers
+          %ul
+            %li.stage-header
+              %span.stage-name
+                Stage
+              %i.has-tooltip.fa.fa-question-circle{ "data-placement" => "top", title: "The phase of the development lifecycle.", "aria-hidden" => "true" }
+            %li.median-header
+              %span.stage-name
+                Median
+              %i.has-tooltip.fa.fa-question-circle{ "data-placement" => "top", title: "The value lying at the midpoint of a series of observed values. E.g., between 3, 5, 9, the median is 5. Between 3, 5, 7, 8, the median is (5+7)/2 = 6.", "aria-hidden" => "true" }
+            %li.event-header
+              %span.stage-name
+                {{ currentStage ? currentStage.legend : 'Related Issues' }}
+              %i.has-tooltip.fa.fa-question-circle{ "data-placement" => "top", title: "The collection of events added to the data gathered for that stage.", "aria-hidden" => "true" }
+            %li.total-time-header
+              %span.stage-name
+                Total Time
+              %i.has-tooltip.fa.fa-question-circle{ "data-placement" => "top", title: "The time taken by each data entry gathered by that stage.", "aria-hidden" => "true" }
+      .stage-panel-body
+        %nav.stage-nav
+          %ul
+            %li.stage-nav-item{ ':class' => '{ active: stage.active }', '@click' => 'selectStage(stage)', "v-for" => "stage in state.stages" }
+              .stage-name
+                {{ stage.title }}
+              .stage-median
+                %template{ "v-if" => "stage.isUserAllowed" }
+                  %span{ "v-if" => "stage.value" }
+                    {{ stage.value }}
+                  %span.stage-empty{ "v-else" => true }
+                    No enough data
+                %template{ "v-else" => true }
+                  %span.not-available
+                    Not available
+        .section.stage-events
+          %template{ "v-if" => "isLoadingStage" }
+            = icon("spinner spin")
+          %template{ "v-if" => "currentStage && !currentStage.isUserAllowed" }
+            = render partial: "no_access"
+          %template{ "v-else" => true }
+            %template{ "v-if" => "isEmptyStage && !isLoadingStage" }
+              = render partial: "empty_stage"
+            %template{ "v-if" => "state.events.length && !isLoadingStage && !isEmptyStage" }
+              %component{ ":is" => "currentStage.component", ":stage" => "currentStage", ":items" => "state.events" }
-- 
GitLab