Fix trailing space issue with merge requests and issues. Fixes #2514

CHANGELOG

@@ -30,6 +30,7 @@ v 8.2.0 (unreleased)
   - Fix incoming email config defaults
   - MR target branch is now visible on a list view when it is different from project's default one
   - Improve Continuous Integration graphs page
+  - Fix trailing whitespace issue in merge request/issue title
 v 8.1.4
   - Fix bug where manually merged branches in a MR would end up with an empty diff (Stan Hu)

app/controllers/projects/issues_controller.rb

@@ -158,10 +158,12 @@ class Projects::IssuesController < Projects::ApplicationController
   end
   def issue_params
-    params.require(:issue).permit(
+    permitted = params.require(:issue).permit(
       :title, :assignee_id, :position, :description,
       :milestone_id, :state_event, :task_num, label_ids: []
     )
+    params[:issue][:title].strip! if params[:issue][:title]
+    permitted
   end
   def bulk_update_params

app/controllers/projects/merge_requests_controller.rb

@@ -276,11 +276,13 @@ class Projects::MergeRequestsController < Projects::ApplicationController
   end
   def merge_request_params
-    params.require(:merge_request).permit(
+    permitted = params.require(:merge_request).permit(
       :title, :assignee_id, :source_project_id, :source_branch,
       :target_project_id, :target_branch, :milestone_id,
       :state_event, :description, :task_num, label_ids: []
     )
+    params[:merge_request][:title].strip! if params[:merge_request][:title]
+    permitted
   end
   # Make sure merge requests created before 8.0