Merge branch 'fix/gb/fix-registry-for-uppercased-project-paths' into 'master'

Fix registry for projects with uppercases in path

Closes #30880

See merge request !10674

app/models/container_repository.rb

@@ -20,7 +20,8 @@ class ContainerRepository < ActiveRecord::Base
   end
   def path
-    @path ||= [project.full_path, name].select(&:present?).join('/')
+    @path ||= [project.full_path, name]
+      .select(&:present?).join('/').downcase
   end
   def location

lib/container_registry/path.rb

@@ -15,7 +15,7 @@ module ContainerRegistry
     LEVELS_SUPPORTED = 3
     def initialize(path)
-      @path = path
+      @path = path.to_s.downcase
     end
     def valid?
@@ -25,7 +25,7 @@ module ContainerRegistry
     end
     def components
-      @components ||= @path.to_s.split('/')
+      @components ||= @path.split('/')
     end
     def nodes

spec/lib/container_registry/path_spec.rb

@@ -33,10 +33,20 @@ describe ContainerRegistry::Path do
   end
   describe '#to_s' do
-    let(:path) { 'some/image' }
-    it 'return a string with a repository path' do
-      expect(subject.to_s).to eq path
+    context 'when path does not have uppercase characters' do
+      let(:path) { 'some/image' }
+      it 'return a string with a repository path' do
+        expect(subject.to_s).to eq 'some/image'
+      end
+    end
+
+    context 'when path has uppercase characters' do
+      let(:path) { 'SoMe/ImAgE' }
+
+      it 'return a string with a repository path' do
+        expect(subject.to_s).to eq 'some/image'
+      end
     end
   end
@@ -70,6 +80,12 @@ describe ContainerRegistry::Path do
       it { is_expected.to be_valid }
     end
+
+    context 'when path contains uppercase letters' do
+      let(:path) { 'Some/Registry' }
+
+      it { is_expected.to be_valid }
+    end
   end
   describe '#has_repository?' do

spec/models/container_repository_spec.rb

@@ -34,8 +34,18 @@ describe ContainerRepository do
   end
   describe '#path' do
-    it 'returns a full path to the repository' do
-      expect(repository.path).to eq('group/test/my_image')
+    context 'when project path does not contain uppercase letters' do
+      it 'returns a full path to the repository' do
+        expect(repository.path).to eq('group/test/my_image')
+      end
+    end
+
+    context 'when path contains uppercase letters' do
+      let(:project) { create(:project, path: 'MY_PROJECT', group: group) }
+
+      it 'returns a full path without capital letters' do
+        expect(repository.path).to eq('group/my_project/my_image')
+      end
     end
   end