From 82c500a2b69e985cb12ce89964c6ebdd289a0d23 Mon Sep 17 00:00:00 2001
From: Connor Shea <connor.james.shea@gmail.com>
Date: Wed, 13 Jul 2016 12:39:14 -0600
Subject: [PATCH] Disable all cops with offenses.
---
.rubocop_todo.yml | 183 +++++++++-------------------------------------
1 file changed, 34 insertions(+), 149 deletions(-)
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 3478d86f1fa..9310e711889 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
# This configuration was generated by
-# `rubocop --auto-gen-config --exclude-limit 8`
-# on 2016-07-13 12:03:44 -0600 using RuboCop version 0.41.2.
+# `rubocop --auto-gen-config --exclude-limit 0`
+# on 2016-07-13 12:36:08 -0600 using RuboCop version 0.41.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
@@ -25,9 +25,7 @@ Lint/IneffectiveAccessModifier:
# Offense count: 2
Lint/Loop:
- Exclude:
- - 'app/mailers/notify.rb'
- - 'lib/gitlab/bitbucket_import/client.rb'
+ Enabled: false
# Offense count: 15
Lint/ShadowingOuterLocalVariable:
@@ -36,10 +34,7 @@ Lint/ShadowingOuterLocalVariable:
# Offense count: 3
# Cop supports --auto-correct.
Lint/StringConversionInInterpolation:
- Exclude:
- - 'app/models/commit_range.rb'
- - 'app/services/system_hooks_service.rb'
- - 'app/services/system_note_service.rb'
+ Enabled: false
# Offense count: 44
# Cop supports --auto-correct.
@@ -60,30 +55,17 @@ Lint/UselessAccessModifier:
# Offense count: 12
# Cop supports --auto-correct.
Performance/PushSplat:
- Exclude:
- - 'app/controllers/projects/refs_controller.rb'
- - 'app/helpers/page_layout_helper.rb'
- - 'app/models/ability.rb'
- - 'app/models/network/graph.rb'
- - 'app/models/project_team.rb'
- - 'app/models/user.rb'
- - 'config/application.rb'
+ Enabled: false
# Offense count: 2
# Cop supports --auto-correct.
Performance/RedundantBlockCall:
- Exclude:
- - 'app/controllers/application_controller.rb'
- - 'lib/gitlab/backend/shell.rb'
+ Enabled: false
# Offense count: 4
# Cop supports --auto-correct.
Performance/RedundantMatch:
- Exclude:
- - 'app/models/external_issue.rb'
- - 'lib/extracts_path.rb'
- - 'lib/gitlab/diff/highlight.rb'
- - 'lib/gitlab/diff/parser.rb'
+ Enabled: false
# Offense count: 24
# Cop supports --auto-correct.
@@ -138,12 +120,7 @@ Style/BracesAroundHashParameters:
# Offense count: 5
Style/CaseEquality:
- Exclude:
- - 'app/helpers/auth_helper.rb'
- - 'app/models/commit.rb'
- - 'app/models/protected_branch.rb'
- - 'app/services/projects/download_service.rb'
- - 'config/initializers/trusted_proxies.rb'
+ Enabled: false
# Offense count: 19
# Cop supports --auto-correct.
@@ -155,10 +132,7 @@ Style/ColonMethodCall:
# Configuration parameters: Keywords.
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
Style/CommentAnnotation:
- Exclude:
- - 'app/models/project.rb'
- - 'lib/api/entities.rb'
- - 'spec/requests/api/project_snippets_spec.rb'
+ Enabled: false
# Offense count: 34
# Cop supports --auto-correct.
@@ -167,7 +141,7 @@ Style/CommentAnnotation:
Style/ConditionalAssignment:
Enabled: false
-# Offense count: 788
+# Offense count: 789
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: leading, trailing
@@ -180,10 +154,7 @@ Style/DoubleNegation:
# Offense count: 3
Style/EachWithObject:
- Exclude:
- - 'app/models/commit_status.rb'
- - 'lib/ci/ansi2html.rb'
- - 'lib/gitlab/import_export/members_mapper.rb'
+ Enabled: false
# Offense count: 30
# Cop supports --auto-correct.
@@ -195,10 +166,7 @@ Style/EmptyElse:
# Offense count: 3
# Cop supports --auto-correct.
Style/EmptyLiteral:
- Exclude:
- - 'features/steps/project/commits/commits.rb'
- - 'lib/gitlab/fogbugz_import/importer.rb'
- - 'spec/lib/gitlab/workhorse_spec.rb'
+ Enabled: false
# Offense count: 123
# Cop supports --auto-correct.
@@ -210,13 +178,7 @@ Style/ExtraSpacing:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: format, sprintf, percent
Style/FormatString:
- Exclude:
- - 'app/models/ci/pipeline.rb'
- - 'app/services/gravatar_service.rb'
- - 'config/initializers/rack_lineprof.rb'
- - 'lib/ci/version_info.rb'
- - 'lib/gitlab/version_info.rb'
- - 'spec/requests/api/issues_spec.rb'
+ Enabled: false
# Offense count: 48
# Configuration parameters: MinBodyLength.
@@ -233,7 +195,7 @@ Style/IfInsideElse:
Style/IfUnlessModifier:
Enabled: false
-# Offense count: 50
+# Offense count: 52
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
@@ -252,40 +214,21 @@ Style/IndentHash:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: line_count_dependent, lambda, literal
Style/Lambda:
- Exclude:
- - 'app/models/ci/runner.rb'
- - 'app/models/event.rb'
- - 'app/models/note.rb'
- - 'app/models/notification_setting.rb'
- - 'config/routes.rb'
- - 'lib/api/entities.rb'
- - 'spec/models/concerns/participable_spec.rb'
+ Enabled: false
# Offense count: 6
# Cop supports --auto-correct.
Style/LineEndConcatenation:
- Exclude:
- - 'app/helpers/preferences_helper.rb'
- - 'app/helpers/tree_helper.rb'
- - 'app/models/merge_request.rb'
- - 'app/models/user.rb'
- - 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
+ Enabled: false
# Offense count: 13
# Cop supports --auto-correct.
Style/MethodCallParentheses:
- Exclude:
- - 'lib/api/helpers.rb'
- - 'lib/ci/ansi2html.rb'
- - 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
- - 'spec/helpers/submodule_helper_spec.rb'
- - 'spec/workers/post_receive_spec.rb'
+ Enabled: false
# Offense count: 3
Style/MultilineTernaryOperator:
- Exclude:
- - 'lib/banzai/filter/relative_link_filter.rb'
- - 'spec/support/api_helpers.rb'
+ Enabled: false
# Offense count: 62
# Cop supports --auto-correct.
@@ -295,12 +238,7 @@ Style/MutableConstant:
# Offense count: 10
# Cop supports --auto-correct.
Style/NestedParenthesizedCalls:
- Exclude:
- - 'app/helpers/commits_helper.rb'
- - 'app/workers/irker_worker.rb'
- - 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
- - 'spec/lib/gitlab/email/message/repository_push_spec.rb'
- - 'spec/services/ci/create_builds_service_spec.rb'
+ Enabled: false
# Offense count: 12
# Cop supports --auto-correct.
@@ -314,13 +252,7 @@ Style/Next:
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
# SupportedOctalStyles: zero_with_o, zero_only
Style/NumericLiteralPrefix:
- Exclude:
- - 'config/initializers/1_settings.rb'
- - 'config/initializers/secret_token.rb'
- - 'lib/gitlab/backend/shell.rb'
- - 'spec/lib/gitlab/git/hook_spec.rb'
- - 'spec/support/test_env.rb'
- - 'spec/tasks/gitlab/backup_rake_spec.rb'
+ Enabled: false
# Offense count: 29
# Cop supports --auto-correct.
@@ -338,12 +270,7 @@ Style/PercentLiteralDelimiters:
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: lower_case_q, upper_case_q
Style/PercentQLiterals:
- Exclude:
- - 'spec/helpers/gitlab_markdown_helper_spec.rb'
- - 'spec/lib/gitlab/diff/highlight_spec.rb'
- - 'spec/models/project_services/bamboo_service_spec.rb'
- - 'spec/models/project_services/teamcity_service_spec.rb'
- - 'spec/workers/repository_import_worker_spec.rb'
+ Enabled: false
# Offense count: 13
# Cop supports --auto-correct.
@@ -366,12 +293,7 @@ Style/PreferredHashMethods:
# Offense count: 6
# Cop supports --auto-correct.
Style/Proc:
- Exclude:
- - 'app/mailers/base_mailer.rb'
- - 'app/models/label.rb'
- - 'app/models/service.rb'
- - 'lib/api/api_guard.rb'
- - 'spec/initializers/trusted_proxies_spec.rb'
+ Enabled: false
# Offense count: 20
# Cop supports --auto-correct.
@@ -383,16 +305,12 @@ Style/RaiseArgs:
# Offense count: 3
# Cop supports --auto-correct.
Style/RedundantBegin:
- Exclude:
- - 'app/models/ci/build.rb'
- - 'app/models/merge_request.rb'
- - 'app/services/projects/import_service.rb'
+ Enabled: false
# Offense count: 1
# Cop supports --auto-correct.
Style/RedundantException:
- Exclude:
- - 'app/helpers/preferences_helper.rb'
+ Enabled: false
# Offense count: 23
# Cop supports --auto-correct.
@@ -419,24 +337,19 @@ Style/RescueModifier:
# Offense count: 2
# Cop supports --auto-correct.
Style/SelfAssignment:
- Exclude:
- - 'app/services/notification_service.rb'
- - 'lib/api/runners.rb'
+ Enabled: false
# Offense count: 2
# Configuration parameters: Methods.
# Methods: {"reduce"=>["a", "e"]}, {"inject"=>["a", "e"]}
Style/SingleLineBlockParams:
- Exclude:
- - 'app/models/commit.rb'
- - 'spec/support/services_shared_context.rb'
+ Enabled: false
# Offense count: 50
# Cop supports --auto-correct.
# Configuration parameters: AllowIfMethodIsEmpty.
Style/SingleLineMethods:
- Exclude:
- - 'lib/ci/ansi2html.rb'
+ Enabled: false
# Offense count: 14
# Cop supports --auto-correct.
@@ -456,15 +369,7 @@ Style/SpaceBeforeBlockBraces:
# Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment.
Style/SpaceBeforeFirstArg:
- Exclude:
- - 'config/initializers/doorkeeper.rb'
- - 'config/routes.rb'
- - 'features/steps/project/source/browse_files.rb'
- - 'features/steps/project/source/markdown_render.rb'
- - 'spec/routing/project_routing_spec.rb'
- - 'spec/services/delete_user_service_spec.rb'
- - 'spec/services/projects/fork_service_spec.rb'
- - 'spec/services/system_note_service_spec.rb'
+ Enabled: false
# Offense count: 130
# Cop supports --auto-correct.
@@ -486,9 +391,7 @@ Style/SpaceInsideParens:
# Offense count: 5
# Cop supports --auto-correct.
Style/SpaceInsidePercentLiteralDelimiters:
- Exclude:
- - 'lib/event_filter.rb'
- - 'lib/gitlab/git_access.rb'
+ Enabled: false
# Offense count: 36
# Cop supports --auto-correct.
@@ -518,7 +421,7 @@ Style/SymbolProc:
Style/TrailingCommaInArguments:
Enabled: false
-# Offense count: 114
+# Offense count: 113
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
# SupportedStyles: comma, consistent_comma, no_comma
@@ -529,13 +432,7 @@ Style/TrailingCommaInLiteral:
# Cop supports --auto-correct.
# Configuration parameters: AllowNamedUnderscoreVariables.
Style/TrailingUnderscoreVariable:
- Exclude:
- - 'app/controllers/admin/background_jobs_controller.rb'
- - 'app/controllers/invites_controller.rb'
- - 'app/controllers/projects/git_http_controller.rb'
- - 'app/helpers/tab_helper.rb'
- - 'lib/gitlab/checks/force_push.rb'
- - 'lib/gitlab/logger.rb'
+ Enabled: false
# Offense count: 90
# Cop supports --auto-correct.
@@ -547,17 +444,12 @@ Style/TrailingWhitespace:
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors:
- Exclude:
- - 'app/models/external_issue.rb'
- - 'lib/gitlab/ldap/person.rb'
+ Enabled: false
# Offense count: 3
# Cop supports --auto-correct.
Style/UnlessElse:
- Exclude:
- - 'lib/api/projects.rb'
- - 'lib/gitlab/backend/grack_auth.rb'
- - 'lib/gitlab/project_search_results.rb'
+ Enabled: false
# Offense count: 13
# Cop supports --auto-correct.
@@ -567,11 +459,4 @@ Style/UnneededInterpolation:
# Offense count: 8
# Cop supports --auto-correct.
Style/ZeroLengthPredicate:
- Exclude:
- - 'app/models/deploy_key.rb'
- - 'app/models/network/commit.rb'
- - 'app/models/network/graph.rb'
- - 'app/models/project_services/asana_service.rb'
- - 'app/models/repository.rb'
- - 'lib/extracts_path.rb'
- - 'lib/gitlab/checks/force_push.rb'
+ Enabled: false
--
GitLab