From 98217bc0674253f30dea3892a8e833436b89d5b9 Mon Sep 17 00:00:00 2001
From: Lin Jen-Shin <godfat@godfat.org>
Date: Mon, 17 Oct 2016 18:03:53 +0800
Subject: [PATCH] should_email_no_one -> should_not_email_anyone, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342/diffs#note_17039876
---
spec/models/ci/pipeline_spec.rb | 2 +-
spec/services/notification_service_spec.rb | 4 ++--
spec/support/email_helpers.rb | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/spec/models/ci/pipeline_spec.rb b/spec/models/ci/pipeline_spec.rb
index 6ea712ae1b3..85820a9dc57 100644
--- a/spec/models/ci/pipeline_spec.rb
+++ b/spec/models/ci/pipeline_spec.rb
@@ -551,7 +551,7 @@ describe Ci::Pipeline, models: true do
shared_examples 'not sending any notification' do
it 'does not send any email' do
- should_email_no_one
+ should_not_email_anyone
end
end
diff --git a/spec/services/notification_service_spec.rb b/spec/services/notification_service_spec.rb
index 84c22631c67..8ce35354c22 100644
--- a/spec/services/notification_service_spec.rb
+++ b/spec/services/notification_service_spec.rb
@@ -17,7 +17,7 @@ describe NotificationService, services: true do
it 'sends no emails when no new mentions are present' do
send_notifications
- should_email_no_one
+ should_not_email_anyone
end
it 'emails new mentions with a watch level higher than participant' do
@@ -27,7 +27,7 @@ describe NotificationService, services: true do
it 'does not email new mentions with a watch level equal to or less than participant' do
send_notifications(@u_participating, @u_mentioned)
- should_email_no_one
+ should_not_email_anyone
end
end
diff --git a/spec/support/email_helpers.rb b/spec/support/email_helpers.rb
index caa6ab1345a..36f5a2d5975 100644
--- a/spec/support/email_helpers.rb
+++ b/spec/support/email_helpers.rb
@@ -23,7 +23,7 @@ module EmailHelpers
expect(sent_to_user?(user, recipients)).to be_falsey
end
- def should_email_no_one
+ def should_not_email_anyone
expect(ActionMailer::Base.deliveries).to be_empty
end
--
GitLab