From a01623882ed8eb10f1b3d2b6431d7cfdefd68ae1 Mon Sep 17 00:00:00 2001
From: Lin Jen-Shin <godfat@godfat.org>
Date: Wed, 15 Jun 2016 16:18:40 +0800
Subject: [PATCH] Avoid assignment in if
---
lib/gitlab/email/receiver.rb | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/gitlab/email/receiver.rb b/lib/gitlab/email/receiver.rb
index fef9ee8402b..77ed6b9f7d9 100644
--- a/lib/gitlab/email/receiver.rb
+++ b/lib/gitlab/email/receiver.rb
@@ -28,8 +28,9 @@ module Gitlab
mail = build_mail
mail_key = extract_mail_key(mail)
+ handler = Handler.for(mail, mail_key)
- if handler = Handler.for(mail, mail_key)
+ if handler
handler.execute
else
raise UnknownIncomingEmail
--
GitLab